Aaron Schulz has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392491 )

Change subject: Use a meaningful key name in getBookFromCache()
......................................................................

Use a meaningful key name in getBookFromCache()

Change-Id: I6bf80012505f3ba1c37c76d2934d6f086d735d1d
(cherry picked from commit 780e6ae5296e67f30238cd508fb53ae23ba298a4)
---
M includes/BookRenderingMediator.php
1 file changed, 4 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Collection 
refs/changes/91/392491/1

diff --git a/includes/BookRenderingMediator.php 
b/includes/BookRenderingMediator.php
index 9d30550..9c7d068 100644
--- a/includes/BookRenderingMediator.php
+++ b/includes/BookRenderingMediator.php
@@ -95,7 +95,10 @@
                                return in_array( $key, [ 'type', 'title', 
'revision' ], true );
                        } );
                }, $keyBase['items'] );
-               $key = $this->htmlCache->makeGlobalKey( md5( json_encode( 
$keyBase ) ) );
+               $key = $this->htmlCache->makeGlobalKey(
+                       'collection-book',
+                       md5( json_encode( $keyBase ) )
+               );
 
                $book = $this->htmlCache->get( $key );
                if ( !$book ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/392491
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6bf80012505f3ba1c37c76d2934d6f086d735d1d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Collection
Gerrit-Branch: wmf/1.31.0-wmf.8
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to