jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392300 )
Change subject: makeSpecialUrlSubpage() expects parameter to not be url encoded
......................................................................
makeSpecialUrlSubpage() expects parameter to not be url encoded
It's also not supposed to take a subpage at all (Triggers a warning
about aliases when $wgDevelopmentalWarnings is on) so replace with
makeSpecialUrlSubpage.
This fixes issue where Contributors extension didn't work on pages
containing apostrophes or non-ascii characters.
Bug: T152492
Change-Id: I424703f99adf837f6217872b882d1ea26bfdd123
---
M includes/ContributorsHooks.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Brian Wolff: Looks good to me, approved
jenkins-bot: Verified
Martineznovo: Looks good to me, but someone else must approve
diff --git a/includes/ContributorsHooks.php b/includes/ContributorsHooks.php
index 6aaa6f4..e52000f 100644
--- a/includes/ContributorsHooks.php
+++ b/includes/ContributorsHooks.php
@@ -70,8 +70,8 @@
if ( $skintemplate->getTitle()->getNamespace() === NS_MAIN &&
$revid !== 0 ) {
$nav_urls['contributors'] = [
'text' => $skintemplate->msg(
'contributors-toolbox' ),
- 'href' => $skintemplate->makeSpecialUrl(
- 'Contributors/' . wfUrlencode(
$skintemplate->thispage )
+ 'href' => $skintemplate->makeSpecialUrlSubpage(
+ 'Contributors', $skintemplate->thispage
),
];
}
--
To view, visit https://gerrit.wikimedia.org/r/392300
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I424703f99adf837f6217872b882d1ea26bfdd123
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Contributors
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: Brian Wolff <bawolff...@gmail.com>
Gerrit-Reviewer: Devirk <devikrishna...@gmail.com>
Gerrit-Reviewer: Filip <r...@protonmail.com>
Gerrit-Reviewer: Martineznovo <martinezn...@gmail.com>
Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
