Ryan Lane has submitted this change and it was merged.
Change subject: Don't announce comments on drafts to IRC
......................................................................
Don't announce comments on drafts to IRC
Bug: 37538
Change-Id: I8662bf45f1fb89fcb0695b559617fc584fc17318
---
M files/gerrit/hooks/comment-added
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Ryan Lane: Looks good to me, approved
Demon: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/files/gerrit/hooks/comment-added b/files/gerrit/hooks/comment-added
index 3e87aaf..c3a8bfa 100755
--- a/files/gerrit/hooks/comment-added
+++ b/files/gerrit/hooks/comment-added
@@ -16,7 +16,10 @@
self.parser.add_option("--topic", dest="topic")
self.parser.add_option("--VRIF", dest="verified")
self.parser.add_option("--CRVW", dest="codereview")
+ self.parser.add_option("--is-draft", dest="draft")
(options, args) = self.parser.parse_args()
+ if options.draft == "true":
+ return # Don't report drafts to IRC!
comment = re.sub(r"^\s*Patch Set \d+:.*$", '', options.comment,
flags=re.MULTILINE).strip().splitlines()
if comment:
comment = comment[0]
--
To view, visit https://gerrit.wikimedia.org/r/53759
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8662bf45f1fb89fcb0695b559617fc584fc17318
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Demon <[email protected]>
Gerrit-Reviewer: Demon <[email protected]>
Gerrit-Reviewer: Ryan Lane <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
