jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/390040 )
Change subject: Run phpcbf last in composer fix script
......................................................................
Run phpcbf last in composer fix script
In some bizarre reinterpretation of Unix exit codes, phpcbf returns exit
code 1 (EXIT_FAILURE on POSIX-compliant systems and most other Unix
systems) if it fixed all fixable problems and there were no unfixable
problems, which prevents the rest of the fix script from running. Since
ignoring that particular exit code (or even just || true) would require
platform-specific code, we just move phpcbf to the end of the fix script
– if it exits nonzero, the job will fail, but at least all other fixes
will already have been applied.
Change-Id: Icdbf34d4bb2da51d138311a32ba62338b892b732
---
M composer.json
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Thiemo Mättig (WMDE): Looks good to me, approved
diff --git a/composer.json b/composer.json
index 962b95d..3a85c7b 100644
--- a/composer.json
+++ b/composer.json
@@ -49,8 +49,8 @@
},
"scripts": {
"fix": [
- "phpcbf",
- "minus-x fix ."
+ "minus-x fix .",
+ "phpcbf"
],
"test": [
"composer validate --no-interaction",
--
To view, visit https://gerrit.wikimedia.org/r/390040
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icdbf34d4bb2da51d138311a32ba62338b892b732
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQualityConstraints
Gerrit-Branch: master
Gerrit-Owner: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: Lucas Werkmeister (WMDE) <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
