Jcrespo has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/392651 )

Change subject: proxysql: Make proxy configuration non-readable for all users
......................................................................


proxysql: Make proxy configuration non-readable for all users

There should be no state configuration on the configuration, so
no need to make it public.

Configuration would be done by the SQL interface.

Bug: T175672
Change-Id: I25c311b723b093c03e0e52b623ddad132c384cd7
---
M modules/proxysql/manifests/init.pp
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  jenkins-bot: Verified
  Jcrespo: Looks good to me, approved



diff --git a/modules/proxysql/manifests/init.pp 
b/modules/proxysql/manifests/init.pp
index f3cd70e0..df6391c 100644
--- a/modules/proxysql/manifests/init.pp
+++ b/modules/proxysql/manifests/init.pp
@@ -22,8 +22,8 @@
     file { '/etc/proxysql.cnf':
         ensure  => present,
         owner   => 'root',
-        group   => 'root',
-        mode    => '0444',
+        group   => 'root', # this is wrong, this should be its own group/user
+        mode    => '0440',
         content => template('proxysql/proxysql.cnf.erb'),
     }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/392651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25c311b723b093c03e0e52b623ddad132c384cd7
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Jcrespo <jcre...@wikimedia.org>
Gerrit-Reviewer: Jcrespo <jcre...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to