Ladsgroup has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392663 )

Change subject: Remove some of IE8 hacks
......................................................................

Remove some of IE8 hacks

Mediawiki doesn't support js in IE8 anymore

Bug: T123218
Change-Id: Iaded6c2449cdcbb83f6a77f861c0ad67b761860c
---
M view/resources/wikibase/templates.js
1 file changed, 0 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/63/392663/1

diff --git a/view/resources/wikibase/templates.js 
b/view/resources/wikibase/templates.js
index a52bdaa..a5396cb 100644
--- a/view/resources/wikibase/templates.js
+++ b/view/resources/wikibase/templates.js
@@ -64,9 +64,6 @@
                        filteredString = '',
                        character = '';
 
-               // ignore case since IE8 will convert tag names to upper case
-               string = string.replace( /<\/?t(?:head|body|foot)[^>]*>/gi, '' 
);
-
                // strip white space between tags as well since it might cause 
interference
                string = string.replace( />\s+</g, '><' );
 
@@ -100,25 +97,8 @@
                                readTag = false;
                                outTag = true;
                                filteredString += character;
-                       } else if ( outTag && /\s/.test( character ) ) {
-                               continue; // omit white space between tag and 
text (IE8)
-                       } else if ( ( !inTag || inTag && readTag )
-                               // Strip line breaks inserted by IE8 that are 
not stripped by the regular expression
-                               // before the for loop:
-                               && character.charCodeAt( 0 ) !== 10
-                               && character.charCodeAt( 0 ) !== 13
-                       ) {
-                               filteredString += character;
-                               if ( outTag ) {
-                                       outTag = false;
-                               }
                        }
                }
-
-               // We are not interested in letter case and since IE8 is 
causing problems due to having
-               // jQuery parse the template will convert the tag names to 
upper case, just convert the
-               // whole string to lower case.
-               string = filteredString.toLowerCase();
 
                return string;
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/392663
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaded6c2449cdcbb83f6a77f861c0ad67b761860c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to