Chelsyx has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392699 )
Change subject: Change grouping color in survival plots ...................................................................... Change grouping color in survival plots Change-Id: Iacb7d2c295e820b1ac802d72fe7001a4b28b7f95 --- M modules/interleaved_test/page_dwelltime.R M modules/stat_test/serp_from_autocomplete.R M modules/stat_test/visited_page.R 3 files changed, 16 insertions(+), 10 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/autoreporter refs/changes/99/392699/1 diff --git a/modules/interleaved_test/page_dwelltime.R b/modules/interleaved_test/page_dwelltime.R index 99c7aae..a01926c 100644 --- a/modules/interleaved_test/page_dwelltime.R +++ b/modules/interleaved_test/page_dwelltime.R @@ -18,9 +18,10 @@ xlab = "T (Dwell Time in seconds)", ylab = "Proportion of visits longer than T (P%)", surv.scale = "percent", - palette = colorRampPalette(RColorBrewer::brewer.pal(9, "Dark2"))(2 * length(report_params$interleaved_group_names)), + color = "team", + palette = "Dark2", legend = "bottom", - legend.title = "", + legend.title = "Team", ggtheme = wmf::theme_facet() ) p <- ggsurv$plot + @@ -42,9 +43,10 @@ xlab = "T (Dwell Time in seconds)", ylab = "Proportion of visits longer than T (P%)", surv.scale = "percent", - palette = colorRampPalette(RColorBrewer::brewer.pal(9, "Dark2"))(2 * n_wiki), + color = "team", + palette = "Dark2", legend = "bottom", - legend.title = "", + legend.title = "Team", ggtheme = wmf::theme_facet() ) p <- ggsurv$plot + diff --git a/modules/stat_test/serp_from_autocomplete.R b/modules/stat_test/serp_from_autocomplete.R index ca7cde1..d89fa58 100644 --- a/modules/stat_test/serp_from_autocomplete.R +++ b/modules/stat_test/serp_from_autocomplete.R @@ -34,9 +34,10 @@ xlab = "T (Dwell Time in seconds)", ylab = "Proportion of SERPs longer than T (P%)", surv.scale = "percent", + color = "group", palette = "Set1", legend = "bottom", - legend.title = "", + legend.title = "Group", legend.labs = traditional_test_groups, ggtheme = wmf::theme_min() ) @@ -59,9 +60,10 @@ xlab = "T (Dwell Time in seconds)", ylab = "Proportion of SERPs longer than T (P%)", surv.scale = "percent", - palette = colorRampPalette(RColorBrewer::brewer.pal(9, "Set1"))(n_wiki * length(traditional_test_groups)), + color = "group", + palette = "Set1", legend = "bottom", - legend.title = "", + legend.title = "Group", ggtheme = wmf::theme_facet() ) p <- ggsurv$plot + diff --git a/modules/stat_test/visited_page.R b/modules/stat_test/visited_page.R index ca0df0f..e8383b6 100644 --- a/modules/stat_test/visited_page.R +++ b/modules/stat_test/visited_page.R @@ -9,9 +9,10 @@ xlab = "T (Dwell Time in seconds)", ylab = "Proportion of visits longer than T (P%)", surv.scale = "percent", + color = "group", palette = "Set1", legend = "bottom", - legend.title = "", + legend.title = "Group", legend.labs = traditional_test_groups, ggtheme = wmf::theme_min() ) @@ -48,9 +49,10 @@ xlab = "T (Dwell Time in seconds)", ylab = "Proportion of visits longer than T (P%)", surv.scale = "percent", - palette = colorRampPalette(RColorBrewer::brewer.pal(9, "Set1"))(n_wiki * length(traditional_test_groups)), + color = "group", + palette = "Set1", legend = "bottom", - legend.title = "", + legend.title = "Group", ggtheme = wmf::theme_facet() ) p <- ggsurv$plot + -- To view, visit https://gerrit.wikimedia.org/r/392699 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iacb7d2c295e820b1ac802d72fe7001a4b28b7f95 Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/discovery/autoreporter Gerrit-Branch: master Gerrit-Owner: Chelsyx <c...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits