Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392728 )
Change subject: Add audio files to response
......................................................................
Add audio files to response
Bug: T177430
Change-Id: I4a7b34f5aad0945ac35c6657b07281eebf6a27c3
---
M lib/media.js
1 file changed, 8 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/mobileapps
refs/changes/28/392728/1
diff --git a/lib/media.js b/lib/media.js
index 7f3373e..cbbfd51 100644
--- a/lib/media.js
+++ b/lib/media.js
@@ -9,8 +9,10 @@
const SELECTORS = [
'figure[typeof^=mw:Image]',
'figure[typeof^=mw:Video]',
+ 'figure[typeof^=mw:Audio]',
'span[typeof^=mw:Image]',
- 'span[typeof^=mw:Video]'
+ 'span[typeof^=mw:Video]',
+ 'span[typeof^=mw:Audio]'
];
function MediaType(resourceSelector, name) {
@@ -20,6 +22,7 @@
const Image = new MediaType('img', 'image');
const Video = new MediaType('video', 'video');
+const Audio = new MediaType('video', 'audio');
function getMediaType(typeofAttr) {
switch (typeofAttr.slice(0, 8)) {
@@ -27,6 +30,8 @@
return Image;
case 'mw:Video':
return Video;
+ case 'mw:Audio':
+ return Audio;
default:
return;
}
@@ -90,8 +95,8 @@
// Also reject SVG and PNG items by default, because they're likely to be
// logos and/or presentational images.
return item.url
- && item.width >= MIN_IMAGE_SIZE
- && item.height >= MIN_IMAGE_SIZE
+ && (item.type === Audio.name || item.width >= MIN_IMAGE_SIZE)
+ && (item.type === Audio.name || item.height >= MIN_IMAGE_SIZE)
&& !item.mime.includes('svg')
&& !item.mime.includes('png');
}
--
To view, visit https://gerrit.wikimedia.org/r/392728
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a7b34f5aad0945ac35c6657b07281eebf6a27c3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/services/mobileapps
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
