jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392772 )
Change subject: Use padding instead of margin to close a gap
......................................................................
Use padding instead of margin to close a gap
Clicking between the radio button and the logo should count as
a click on the thing.
Change-Id: I871fcbdd3a67e44be5a0ab2cec14e2d2ddbabb4c
---
M gateway_forms/mustache/forms.css
M gateway_forms/mustache/payment_method.html.mustache
2 files changed, 4 insertions(+), 8 deletions(-)
Approvals:
XenoRyet: Looks good to me, approved
jenkins-bot: Verified
diff --git a/gateway_forms/mustache/forms.css b/gateway_forms/mustache/forms.css
index c74fd0f..cf0dc1e 100644
--- a/gateway_forms/mustache/forms.css
+++ b/gateway_forms/mustache/forms.css
@@ -274,14 +274,12 @@
#cards.three-per-line li {
width: 32.63%;
- padding: 1em;
}
#cards.three-per-line > li:nth-child(3),
#cards.three-per-line > li:nth-child(6) { margin-right: 0; }
#cards.four-per-line li {
width: 24.29%;
- padding: 1em 0.5em;
}
#cards.four-per-line > li:nth-child(4),
#cards.four-per-line > li:nth-child(8) { margin-right: 0; }
@@ -300,16 +298,16 @@
#cards li input {
display: block;
width: 100%;
- margin: 0 0 .7em;
+ margin: 0;
box-shadow: none;
}
#cards li label {
cursor: pointer;
- margin-top: .5em;
+ padding: 1em;
display: block;
}
#cards li label img {
- margin: 0 auto;
+ margin: 0.7em auto 0;
height: auto;
}
#cards li.has_sub_text label {
@@ -484,8 +482,6 @@
border: 1px solid #ccc;
}
#cards li input.cardradio {
- padding: 10px;
- margin: 5px 0;
display: block;
width: auto;
font-size: 13px;
diff --git a/gateway_forms/mustache/payment_method.html.mustache
b/gateway_forms/mustache/payment_method.html.mustache
index 27e688a..b39a439 100644
--- a/gateway_forms/mustache/payment_method.html.mustache
+++ b/gateway_forms/mustache/payment_method.html.mustache
@@ -6,8 +6,8 @@
<ul class="options-h enabled {{ button_class }}" id="cards">
{{# submethods }} {{! TODO: give every submethod a label_key, remove
conditionals }}
<li title="{{# label_key }}{{
l10n . }}{{/ label_key }}{{^ label_key }}{{ label }}{{/ label_key }}" {{#
sub_text_key }}class="has_sub_text" {{/ sub_text_key }}>
- <input id="submethod-{{ key
}}" name="payment_submethod" type="radio" value="{{ key }}" class="cardradio" />
<label for="submethod-{{ key
}}">
+ <input id="submethod-{{
key }}" name="payment_submethod" type="radio" value="{{ key }}"
class="cardradio" />
<img
class="submethod-logo" alt="{{ label }}" src="{{ logo }}" {{{ srcset }}}/>
{{# sub_text_key }}
<p
class="card_sub_text">{{ l10n . }}</p>
--
To view, visit https://gerrit.wikimedia.org/r/392772
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I871fcbdd3a67e44be5a0ab2cec14e2d2ddbabb4c
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/DonationInterface
Gerrit-Branch: master
Gerrit-Owner: Ejegg <ej...@ejegg.com>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Mepps <me...@wikimedia.org>
Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
