jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392888 )
Change subject: build: Add 'npm run qunit' command
......................................................................
build: Add 'npm run qunit' command
The running of 'grunt qunit' is unconvenient due to it only working
if the user has grunt-cli installed globally, which should not be
needed because it is already installed in the local directory.
It could be worked around by instructing users to use
`./node_modules/.bin/grunt qunit`, but it would be much simpler
to instruct them to use `npm run qunit` instead.
Unlike 'composer', 'npm' does not come by default with a command
like 'composer exec' that one could pass a command directly
without needing to register it. This is fixed in more recent
versions through 'npx -c', but that's a bit too new to require
in the manual, so adding it as a run-script instead.
Change-Id: I2812b13dbed50612b1626a617ba65f92e212f01a
---
M package.json
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/package.json b/package.json
index faca87d..2878eca 100644
--- a/package.json
+++ b/package.json
@@ -2,6 +2,7 @@
"private": true,
"scripts": {
"test": "grunt test",
+ "qunit": "grunt qunit",
"doc": "jsduck",
"postdoc": "grunt copy:jsduck",
"selenium": "killall -0 chromedriver 2>/dev/null || chromedriver
--url-base=/wd/hub --port=4444 & grunt webdriver:test; killall chromedriver"
--
To view, visit https://gerrit.wikimedia.org/r/392888
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2812b13dbed50612b1626a617ba65f92e212f01a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
