jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392891 )
Change subject: InstallDocFormatter: Add missing @covers scope
......................................................................
InstallDocFormatter: Add missing @covers scope
The format() method is a one-line wrapper around execute(), which
is the real method being tested here. Given the class doesn't
contain any other methods, increase the scope to the whole class.
Change-Id: I8b2c7736c6708c0915a9ce15fef0dc85c63621ea
---
M includes/installer/InstallDocFormatter.php
M tests/phpunit/includes/installer/InstallDocFormatterTest.php
2 files changed, 2 insertions(+), 6 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/installer/InstallDocFormatter.php
b/includes/installer/InstallDocFormatter.php
index 4163e2f..08cfd86 100644
--- a/includes/installer/InstallDocFormatter.php
+++ b/includes/installer/InstallDocFormatter.php
@@ -21,7 +21,7 @@
*/
class InstallDocFormatter {
- static function format( $text ) {
+ public static function format( $text ) {
$obj = new self( $text );
return $obj->execute();
diff --git a/tests/phpunit/includes/installer/InstallDocFormatterTest.php
b/tests/phpunit/includes/installer/InstallDocFormatterTest.php
index 36b6d64..9584d4b 100644
--- a/tests/phpunit/includes/installer/InstallDocFormatterTest.php
+++ b/tests/phpunit/includes/installer/InstallDocFormatterTest.php
@@ -1,12 +1,8 @@
<?php
-/*
- * To change this template, choose Tools | Templates
- * and open the template in the editor.
- */
class InstallDocFormatterTest extends MediaWikiTestCase {
/**
- * @covers InstallDocFormatter::format
+ * @covers InstallDocFormatter
* @dataProvider provideDocFormattingTests
*/
public function testFormat( $expected, $unformattedText, $message = ''
) {
--
To view, visit https://gerrit.wikimedia.org/r/392891
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b2c7736c6708c0915a9ce15fef0dc85c63621ea
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Tim Starling <tstarl...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
