Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392909 )
Change subject: Range: Avoid some unnecessary function calls
......................................................................
Range: Avoid some unnecessary function calls
Just access the properties directly.
Change-Id: I146da198d8225ada8393a81c00ddd27b39794241
---
M includes/Range.php
1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ORES
refs/changes/09/392909/1
diff --git a/includes/Range.php b/includes/Range.php
index 1bae28e..259264a 100644
--- a/includes/Range.php
+++ b/includes/Range.php
@@ -67,7 +67,7 @@
* @return bool
*/
public function overlaps( Range $other ) {
- return max( $this->getMin(), $other->getMin() ) <= min(
$this->getMax(), $other->getMax() );
+ return max( $this->min, $other->min ) <= min( $this->max,
$other->max );
}
/**
@@ -76,8 +76,8 @@
* @param Range $other
*/
public function combineWith( Range $other ) {
- $this->min = min( $this->getMin(), $other->getMin() );
- $this->max = max( $this->getMax(), $other->getMax() );
+ $this->min = min( $this->min, $other->min );
+ $this->max = max( $this->max, $other->max );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/392909
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I146da198d8225ada8393a81c00ddd27b39794241
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Legoktm <lego...@member.fsf.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
