Catrope has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392988 )

Change subject: SpecialListgrouprights: Fix "Namespace restrictions" header ID
......................................................................

SpecialListgrouprights: Fix "Namespace restrictions" header ID

* Strip the '#' from the start of the <h2>'s id attribute
* Don't parse the header message. It doesn't contain HTML, and it's used
  as plain text anyway.

Change-Id: I380c20293437dbcd3419f83ea8b7a7ee0bb504f1
---
M includes/specials/SpecialListgrouprights.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/88/392988/1

diff --git a/includes/specials/SpecialListgrouprights.php 
b/includes/specials/SpecialListgrouprights.php
index 2315887..89d0a61 100644
--- a/includes/specials/SpecialListgrouprights.php
+++ b/includes/specials/SpecialListgrouprights.php
@@ -149,11 +149,11 @@
                        return;
                }
 
-               $header = $this->msg( 
'listgrouprights-namespaceprotection-header' )->parse();
+               $header = $this->msg( 
'listgrouprights-namespaceprotection-header' )->text();
                $out->addHTML(
                        Html::rawElement( 'h2', [], Html::element( 'span', [
                                'class' => 'mw-headline',
-                               'id' => 
$wgParser->guessSectionNameFromWikiText( $header )
+                               'id' => substr( 
$wgParser->guessSectionNameFromWikiText( $header ), 1 )
                        ], $header ) ) .
                        Xml::openElement( 'table', [ 'class' => 'wikitable' ] ) 
.
                        Html::element(

-- 
To view, visit https://gerrit.wikimedia.org/r/392988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I380c20293437dbcd3419f83ea8b7a7ee0bb504f1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Catrope <r...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to