Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/392997 )

Change subject: url_downloader: move firewall to role, use profile
......................................................................

url_downloader: move firewall to role, use profile

Change-Id: Ib64fa1d1cd091d2a4ff0b98a88e50572e469d837
---
M modules/profile/manifests/url_downloader.pp
M modules/role/manifests/url_downloader.pp
2 files changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/97/392997/1

diff --git a/modules/profile/manifests/url_downloader.pp 
b/modules/profile/manifests/url_downloader.pp
index 4b846c7..9b71c74 100644
--- a/modules/profile/manifests/url_downloader.pp
+++ b/modules/profile/manifests/url_downloader.pp
@@ -23,7 +23,6 @@
 ) {
 
     include network::constants
-    include ::base::firewall
 
     if $::realm == 'production' {
         $wikimedia = [
diff --git a/modules/role/manifests/url_downloader.pp 
b/modules/role/manifests/url_downloader.pp
index 627ba45..691f976 100644
--- a/modules/role/manifests/url_downloader.pp
+++ b/modules/role/manifests/url_downloader.pp
@@ -4,5 +4,6 @@
     system::role { 'url_downloader': description => 'Upload-by-URL proxy' }
 
     include ::standard
+    include ::profile::base::firewall
     include ::profile::url_downloader
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/392997
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib64fa1d1cd091d2a4ff0b98a88e50572e469d837
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <dz...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to