jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392446 )
Change subject: Add test cases for wbsetclaim API and statements on forms
......................................................................
Add test cases for wbsetclaim API and statements on forms
Bug: T180471
Change-Id: I1812cbbe83e54af874f3c80756511bcab7f17e4b
---
A tests/phpunit/mediawiki/Api/SetClaimTest.php
1 file changed, 293 insertions(+), 0 deletions(-)
Approvals:
Jonas Kress (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/mediawiki/Api/SetClaimTest.php
b/tests/phpunit/mediawiki/Api/SetClaimTest.php
new file mode 100644
index 0000000..5d8ff2e
--- /dev/null
+++ b/tests/phpunit/mediawiki/Api/SetClaimTest.php
@@ -0,0 +1,293 @@
+<?php
+
+namespace Wikibase\Lexeme\Tests\MediaWiki\Api;
+
+use DataValues\StringValue;
+use Revision;
+use Wikibase\DataModel\Entity\Property;
+use Wikibase\DataModel\Entity\PropertyId;
+use Wikibase\DataModel\Services\Lookup\EntityLookup;
+use Wikibase\DataModel\Snak\PropertyValueSnak;
+use Wikibase\DataModel\Statement\Statement;
+use Wikibase\Lexeme\DataModel\FormId;
+use Wikibase\Lexeme\DataModel\Lexeme;
+use Wikibase\Lexeme\DataModel\LexemeId;
+use Wikibase\Lexeme\Tests\DataModel\NewForm;
+use Wikibase\Lexeme\Tests\DataModel\NewLexeme;
+use Wikibase\Lib\Store\EntityStore;
+use Wikibase\Repo\Tests\Api\WikibaseApiTestCase;
+use Wikibase\Repo\WikibaseRepo;
+
+/**
+ * @group Database
+ * @group medium
+ *
+ * @license GPL-2.0+
+ */
+class SetClaimTest extends WikibaseApiTestCase {
+
+ public function testGivenFormId_setClaimAddsStatementOnTheForm() {
+ $this->markTestSkipped( 'wbsetclaim does not work with L1-F1
kind of ids yet' );
+
+ $propertyId = new PropertyId( 'P1' );
+ $this->saveTestProperty( $propertyId );
+
+ $lexemeId = new LexemeId( 'L1' );
+ $formId = new FormId( 'L1-F1' );
+
+ $form = NewForm::havingId( $formId )->build();
+ $lexeme = NewLexeme::havingId( $lexemeId )->withForm( $form
)->build();
+
+ $this->saveLexeme( $lexeme );
+
+ $guid = $formId->getSerialization() .
'$00000000-0000-0000-0000-000000000000';
+ $value = 'test';
+
+ $params = [
+ 'action' => 'wbsetclaim',
+ 'claim' => json_encode( $this->getStatementData( $guid,
$propertyId, $value ) ),
+ ];
+
+ $this->doApiRequestWithToken( $params );
+
+ $form = $this->loadForm( $lexemeId, $formId );
+
+ $statements = $form->getStatements()->getByPropertyId(
$propertyId )->toArray();
+ $statement = $statements[0];
+
+ $this->assertEquals( $value,
$statement->getMainSnak()->getDataValue()->getValue() );
+ $this->assertEquals( $guid, $statement->getGuid() );
+ }
+
+ public function
testGivenFormIdAndGuidOfExistingStatement_setClaimEditsTheStatement() {
+ $this->markTestSkipped( 'wbsetclaim does not work with L1-F1
kind of ids yet' );
+
+ $propertyId = new PropertyId( 'P1' );
+ $this->saveTestProperty( $propertyId );
+
+ $lexemeId = new LexemeId( 'L1' );
+ $formId = new FormId( 'L1-F1' );
+
+ $guid = $formId->getSerialization() .
'$00000000-0000-0000-0000-000000000000';
+
+ $statement = $this->getStatement( $guid, $propertyId, 'test' );
+
+ $form = NewForm::havingId( $formId )->andStatement( $statement
)->build();
+ $lexeme = NewLexeme::havingId( $lexemeId )->withForm( $form
)->build();
+
+ $this->saveLexeme( $lexeme );
+
+ $params = [
+ 'action' => 'wbsetclaim',
+ 'claim' => json_encode( $this->getStatementData( $guid,
$propertyId, 'goat' ) ),
+ ];
+
+ $this->doApiRequestWithToken( $params );
+
+ $form = $this->loadForm( $lexemeId, $formId );
+
+ $statements = $form->getStatements()->getByPropertyId(
$propertyId )->toArray();
+ $statement = $statements[0];
+
+ $this->assertEquals( 'test',
$statement->getMainSnak()->getDataValue()->getValue() );
+ $this->assertEquals( $guid, $statement->getGuid() );
+ }
+
+ public function
testGivenFormIdAndIndex_setClaimReordersStatementsAccordingly() {
+ $this->markTestSkipped( 'wbsetclaim does not work with L1-F1
kind of ids yet' );
+
+ $propertyId = new PropertyId( 'P1' );
+ $this->saveTestProperty( $propertyId );
+
+ $lexemeId = new LexemeId( 'L1' );
+ $formId = new FormId( 'L1-F1' );
+
+ $guidCat = $formId->getSerialization() .
'$00000000-0000-0000-0000-000000000000';
+ $guidGoat = $formId->getSerialization() .
'$66666666-6666-6666-6666-666666666666';
+
+ $statementCat = $this->getStatement( $guidCat, $propertyId,
'cat' );
+ $statementGoat = $this->getStatement( $guidCat, $propertyId,
'goat' );
+
+ $form = NewForm::havingId( $formId )
+ ->andStatement( $statementCat )
+ ->andStatement( $statementGoat )
+ ->build();
+ $lexeme = NewLexeme::havingId( $lexemeId )->withForm( $form
)->build();
+
+ $this->saveLexeme( $lexeme );
+
+ $params = [
+ 'action' => 'wbsetclaim',
+ 'claim' => json_encode( $this->getStatementData(
$guidGoat, $propertyId, 'goat' ) ),
+ 'index' => 0,
+ ];
+
+ $this->doApiRequestWithToken( $params );
+
+ $form = $this->loadForm( $lexemeId, $formId );
+
+ $statements = $form->getStatements()->getByPropertyId(
$propertyId )->toArray();
+ $statement = $statements[0];
+
+ $this->assertEquals( 'goat',
$statement->getMainSnak()->getDataValue()->getValue() );
+ $this->assertEquals( $guidGoat, $statement->getGuid() );
+ }
+
+ public function testGivenFormId_setClaimResponseSetsSuccess() {
+ $this->markTestSkipped( 'wbsetclaim does not work with L1-F1
kind of ids yet' );
+
+ $propertyId = new PropertyId( 'P1' );
+ $this->saveTestProperty( $propertyId );
+
+ $lexemeId = new LexemeId( 'L1' );
+ $formId = new FormId( 'L1-F1' );
+
+ $form = NewForm::havingId( $formId )->build();
+ $lexeme = NewLexeme::havingId( $lexemeId )->withForm( $form
)->build();
+
+ $this->saveLexeme( $lexeme );
+
+ $guid = $formId->getSerialization() .
'$00000000-0000-0000-0000-000000000000';
+ $value = 'test';
+
+ $params = [
+ 'action' => 'wbsetclaim',
+ 'claim' => json_encode( $this->getStatementData( $guid,
$propertyId, $value ) ),
+ ];
+
+ list ( $result, ) = $this->doApiRequestWithToken( $params );
+
+ $this->assertEquals( 1, $result['success'] );
+ }
+
+ // TODO: test statement data in response?
+
+ public function testGivenFormId_setClaimSetsEditSummaryAccordingly() {
+ $this->markTestSkipped( 'wbsetclaim does not work with L1-F1
kind of ids yet' );
+
+ $propertyId = new PropertyId( 'P1' );
+ $this->saveTestProperty( $propertyId );
+
+ $lexemeId = new LexemeId( 'L1' );
+ $formId = new FormId( 'L1-F1' );
+
+ $form = NewForm::havingId( $formId )->build();
+ $lexeme = NewLexeme::havingId( $lexemeId )->withForm( $form
)->build();
+
+ $this->saveLexeme( $lexeme );
+
+ $guid = $formId->getSerialization() .
'$00000000-0000-0000-0000-000000000000';
+ $value = 'test';
+
+ $params = [
+ 'action' => 'wbsetclaim',
+ 'claim' => json_encode( $this->getStatementData( $guid,
$propertyId, $value ) ),
+ ];
+
+ $this->doApiRequestWithToken( $params );
+
+ $revision = $this->loadPageRevision( $lexemeId );
+
+ $this->assertEquals( 'CHANGE ME WHEN DEFINED HOW SUMMARY LOOKS
LIKE', $revision->getComment() );
+ }
+
+ public function
testGivenFormIdAndCustomSummary_setClaimSetsEditSummaryAccordingly() {
+ $this->markTestSkipped( 'wbsetclaim does not work with L1-F1
kind of ids yet' );
+
+ $propertyId = new PropertyId( 'P1' );
+ $this->saveTestProperty( $propertyId );
+
+ $lexemeId = new LexemeId( 'L1' );
+ $formId = new FormId( 'L1-F1' );
+
+ $form = NewForm::havingId( $formId )->build();
+ $lexeme = NewLexeme::havingId( $lexemeId )->withForm( $form
)->build();
+
+ $this->saveLexeme( $lexeme );
+
+ $guid = $formId->getSerialization() .
'$00000000-0000-0000-0000-000000000000';
+ $value = 'test';
+
+ $params = [
+ 'action' => 'wbsetclaim',
+ 'claim' => json_encode( $this->getStatementData( $guid,
$propertyId, $value ) ),
+ 'summary' => 'The best edit ever',
+ ];
+
+ $this->doApiRequestWithToken( $params );
+
+ $revision = $this->loadPageRevision( $lexemeId );
+
+ $this->assertEquals( 'CHANGE ME WHEN DEFINED HOW SUMMARY LOOKS
LIKE', $revision->getComment() );
+ }
+
+ private function saveTestProperty( PropertyId $propertyId ) {
+ $store = $this->getStore();
+
+ $property = new Property( $propertyId, null, 'string' );
+ $store->saveEntity( $property, self::class,
$this->getTestUser()->getUser() );
+ }
+
+ private function saveLexeme( Lexeme $lexeme ) {
+ $store = $this->getStore();
+
+ $store->saveEntity( $lexeme, self::class,
$this->getTestUser()->getUser() );
+ }
+
+ /**
+ * TODO: only pass FormId once FormId can tell what is the lexeme ID
+ * @param LexemeId $lexemeId
+ * @param FormId $formId
+ * @return Lexeme
+ */
+ private function loadForm( LexemeId $lexemeId, FormId $formId ) {
+ $lookup = $this->getLookup();
+
+ /** @var Lexeme $lexeme */
+ $lexeme = $lookup->getEntity( $lexemeId );
+
+ return $lexeme->getForm( $formId );
+ }
+
+ /**
+ * @return EntityStore
+ */
+ private function getStore() {
+ return WikibaseRepo::getDefaultInstance()->getEntityStore();
+ }
+
+ /**
+ * @return EntityLookup
+ */
+ private function getLookup() {
+ return WikibaseRepo::getDefaultInstance()->getEntityLookup();
+ }
+
+ private function getStatementData( $guid, PropertyId $propertyId,
$value ) {
+ return [
+ 'id' => $guid,
+ 'type' => 'claim',
+ 'mainsnak' => [
+ 'snaktype' => 'value',
+ 'property' => $propertyId->getSerialization(),
+ 'datavalue' => [
+ 'value' => $value,
+ 'type' => 'string'
+ ]
+ ]
+ ];
+ }
+
+ private function getStatement( $guid, PropertyId $propertyId, $value ) {
+ $snak = new PropertyValueSnak( $propertyId, new StringValue(
$value ) );
+ return new Statement( $snak, null, null, $guid );
+ }
+
+ private function loadPageRevision( $lexemeId ) {
+ $lookup =
WikibaseRepo::getDefaultInstance()->getEntityRevisionLookup();
+ $revisionId = $lookup->getEntityRevision( $lexemeId
)->getRevisionId();
+
+ return Revision::loadFromId( wfGetDB( DB_MASTER ), $revisionId
);
+ }
+
+}
--
To view, visit https://gerrit.wikimedia.org/r/392446
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1812cbbe83e54af874f3c80756511bcab7f17e4b
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <[email protected]>
Gerrit-Reviewer: Jonas Kress (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
