jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/392202 )

Change subject: List names will now sort alphabetically
......................................................................


List names will now sort alphabetically

Added sort() method to make the names on the list sort alphabetically.

Bug: T175895
Change-Id: I5e81b7cf3c22c0755f3a6ea423656b5f344bd1f3
---
M includes/specials/SpecialNewsletter.php
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Thiemo Mättig (WMDE): Looks good to me, approved



diff --git a/includes/specials/SpecialNewsletter.php 
b/includes/specials/SpecialNewsletter.php
index 9bd005a..1fce661 100644
--- a/includes/specials/SpecialNewsletter.php
+++ b/includes/specials/SpecialNewsletter.php
@@ -427,6 +427,8 @@
                        $subscribersNames[] = $subscriber->getName();
                }
 
+               natcasesort( $subscribersNames );
+
                $fields = [
                        'subscribers' => [
                                'type' => 'textarea',

-- 
To view, visit https://gerrit.wikimedia.org/r/392202
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5e81b7cf3c22c0755f3a6ea423656b5f344bd1f3
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/Newsletter
Gerrit-Branch: master
Gerrit-Owner: SimmeD <[email protected]>
Gerrit-Reviewer: 01tonythomas <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: SimmeD <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to