Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393243 )
Change subject: Assume PageIdentityValue exists in core.
......................................................................
Assume PageIdentityValue exists in core.
Change-Id: I0d7fe65f1d28f84ed89978177eb7c2c507f6b14a
Depends-On: Id36fb61986d5804de5cc1a509f38b2fa3daf73e3
---
M repo/tests/phpunit/includes/Content/EntityHandlerTest.php
1 file changed, 3 insertions(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/43/393243/1
diff --git a/repo/tests/phpunit/includes/Content/EntityHandlerTest.php
b/repo/tests/phpunit/includes/Content/EntityHandlerTest.php
index 2e14f32..1491e13 100644
--- a/repo/tests/phpunit/includes/Content/EntityHandlerTest.php
+++ b/repo/tests/phpunit/includes/Content/EntityHandlerTest.php
@@ -247,12 +247,9 @@
$title->method( 'getLatestRevID' )
->will( $this->returnValue( $id ) );
- // TODO: remove conditional as soon as Title::getPageIdentity()
is in core.
- if ( method_exists( Title::class, 'getPageIdentity' ) ) {
- $page = PageIdentityValue::newFromDBKey( $id, NS_MAIN,
__CLASS__ );
- $title->method( 'getPageIdentity' )
- ->will( $this->returnValue( $page ) );
- }
+ $page = PageIdentityValue::newFromDBKey( $id, NS_MAIN,
__CLASS__ );
+ $title->method( 'getPageIdentity' )
+ ->will( $this->returnValue( $page ) );
$revision = new Revision( [
'id' => $id,
--
To view, visit https://gerrit.wikimedia.org/r/393243
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0d7fe65f1d28f84ed89978177eb7c2c507f6b14a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
