Shirayuki has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/56761


Change subject: Add comments for grep
......................................................................

Add comments for grep

* Move articlefeedbackv5-form-tooltip-$action-own
* Add  articlefeedbackv5-form-$action-own
* Move articlefeedbackv5-form-tooltip-$action-$discussType
* Add  articlefeedbackv5-form-$action-$discussType
* Fix  articlefeedbackv5-noteflyover-$action-description

Change-Id: If8e2f61ec178f46c03d93b6154f189c298dfb7cb
---
M ArticleFeedbackv5.render.php
M SpecialArticleFeedbackv5.php
2 files changed, 22 insertions(+), 17 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ArticleFeedbackv5 
refs/changes/61/56761/1

diff --git a/ArticleFeedbackv5.render.php b/ArticleFeedbackv5.render.php
index 8166f3d..9de0cd2 100644
--- a/ArticleFeedbackv5.render.php
+++ b/ArticleFeedbackv5.render.php
@@ -706,8 +706,6 @@
                                }
 
                                if ( $action ) {
-                                       // Give grep a chance to find the 
usages:
-                                       // 
articlefeedbackv5-form-tooltip-hide-own, 
articlefeedbackv5-form-tooltip-unhide-own
                                        $ownPost =
                                                Html::rawElement(
                                                        'div',
@@ -717,10 +715,14 @@
                                                                array(
                                                                        'id' => 
"articleFeedbackv5-$action-link-$id",
                                                                        'class' 
=> "articleFeedbackv5-$action-link articleFeedbackv5-$action-own-link",
+                                                                       // Give 
grep a chance to find the usages:
+                                                                       // 
articlefeedbackv5-form-tooltip-hide-own, 
articlefeedbackv5-form-tooltip-unhide-own
                                                                        'title' 
=> wfMessage( "articlefeedbackv5-form-tooltip-$action-own" )->text(),
                                                                        'href' 
=> '#',
                                                                        
'data-action' => $action,
                                                                ),
+                                                               // Give grep a 
chance to find the usages:
+                                                               // 
articlefeedbackv5-form-hide-own, articlefeedbackv5-form-unhide-own
                                                                wfMessage( 
"articlefeedbackv5-form-$action-own" )->text()
                                                        )
                                                );
@@ -921,8 +923,6 @@
                                                $class .= " 
articleFeedbackv5-$action-exists-link";
                                        }
 
-                                       // Give grep a chance to find the 
usages:
-                                       // 
articlefeedbackv5-form-tooltip-discuss-talk, 
articlefeedbackv5-form-tooltip-discuss-user
                                        $tools .= Html::rawElement(
                                                'li',
                                                array(),
@@ -931,6 +931,8 @@
                                                        array(
                                                                'id' => 
"articleFeedbackv5-$action-link-$record->aft_id",
                                                                'class' => 
$class,
+                                                               // Give grep a 
chance to find the usages:
+                                                               // 
articlefeedbackv5-form-tooltip-discuss-talk, 
articlefeedbackv5-form-tooltip-discuss-user
                                                                'title' => 
wfMessage( "articlefeedbackv5-form-tooltip-$action-$discussType" )->text(),
                                                                'href' => 
$discussLink,
                                                                'data-action' 
=> $action,
@@ -943,6 +945,9 @@
                                                                
'data-section-edittoken' => $wgUser->getEditToken(),
                                                                
'data-section-watchlist' => (int) $wgUser->isWatched( $discussPage )
                                                        ),
+                                                       // Give grep a chance 
to find the usages:
+                                                       // 
articlefeedbackv5-form-discuss-talk, articlefeedbackv5-form-discuss-user,
+                                                       // 
articlefeedbackv5-form-discuss-talk-exists, 
articlefeedbackv5-form-discuss-user-exists
                                                        wfMessage( 
"articlefeedbackv5-form-$action-$discussType" . ( $sectionExists ? '-exists' : 
'' ) )->text()
                                                )
                                        );
diff --git a/SpecialArticleFeedbackv5.php b/SpecialArticleFeedbackv5.php
index 6f9f8c8..7e4a0bc 100644
--- a/SpecialArticleFeedbackv5.php
+++ b/SpecialArticleFeedbackv5.php
@@ -109,19 +109,19 @@
                $out->setIndexPolicy( 'noindex' );
 
                // these are messages that require some parsing that the 
current JS mw.msg does not yet support
-               // articlefeedbackv5-noteflyover-helpful, 
articlefeedbackv5-noteflyover-undo-helpful,
-               // articlefeedbackv5-noteflyover-unhelpful, 
articlefeedbackv5-noteflyover-undo-unhelpful,
-               // articlefeedbackv5-noteflyover-flag, 
articlefeedbackv5-noteflyover-unflag,
-               // articlefeedbackv5-noteflyover-autoflag, 
articlefeedbackv5-noteflyover-clear-flags,
-               // articlefeedbackv5-noteflyover-feature, 
articlefeedbackv5-noteflyover-unfeature,
-               // articlefeedbackv5-noteflyover-resolve, 
articlefeedbackv5-noteflyover-unresolve,
-               // articlefeedbackv5-noteflyover-noaction, 
articlefeedbackv5-noteflyover-unnoaction,
-               // articlefeedbackv5-noteflyover-inappropriate, 
articlefeedbackv5-noteflyover-uninappropriate,
-               // articlefeedbackv5-noteflyover-archive, 
articlefeedbackv5-noteflyover-unarchive,
-               // articlefeedbackv5-noteflyover-hide, 
articlefeedbackv5-noteflyover-unhide,
-               // articlefeedbackv5-noteflyover-autohide, 
articlefeedbackv5-noteflyover-request,
-               // articlefeedbackv5-noteflyover-unrequest, 
articlefeedbackv5-noteflyover-decline,
-               // articlefeedbackv5-noteflyover-oversight, 
articlefeedbackv5-noteflyover-unoversight
+               // articlefeedbackv5-noteflyover-helpful-description, 
articlefeedbackv5-noteflyover-undo-helpful-description,
+               // articlefeedbackv5-noteflyover-unhelpful-description, 
articlefeedbackv5-noteflyover-undo-unhelpful-description,
+               // articlefeedbackv5-noteflyover-flag-description, 
articlefeedbackv5-noteflyover-unflag-description,
+               // articlefeedbackv5-noteflyover-autoflag-description, 
articlefeedbackv5-noteflyover-clear-flags-description,
+               // articlefeedbackv5-noteflyover-feature-description, 
articlefeedbackv5-noteflyover-unfeature-description,
+               // articlefeedbackv5-noteflyover-resolve-description, 
articlefeedbackv5-noteflyover-unresolve-description,
+               // articlefeedbackv5-noteflyover-noaction-description, 
articlefeedbackv5-noteflyover-unnoaction-description,
+               // articlefeedbackv5-noteflyover-inappropriate-description, 
articlefeedbackv5-noteflyover-uninappropriate-description,
+               // articlefeedbackv5-noteflyover-archive-description, 
articlefeedbackv5-noteflyover-unarchive-description,
+               // articlefeedbackv5-noteflyover-hide-description, 
articlefeedbackv5-noteflyover-unhide-description,
+               // articlefeedbackv5-noteflyover-autohide-description, 
articlefeedbackv5-noteflyover-request-description,
+               // articlefeedbackv5-noteflyover-unrequest-description, 
articlefeedbackv5-noteflyover-decline-description,
+               // articlefeedbackv5-noteflyover-oversight-description, 
articlefeedbackv5-noteflyover-unoversight-description
                $vars = array();
                foreach ( ArticleFeedbackv5Activity::$actions as $action => 
$options ) {
                        $message = wfMessage( 
"articlefeedbackv5-noteflyover-$action-description" )->parse();

-- 
To view, visit https://gerrit.wikimedia.org/r/56761
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If8e2f61ec178f46c03d93b6154f189c298dfb7cb
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ArticleFeedbackv5
Gerrit-Branch: master
Gerrit-Owner: Shirayuki <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to