Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56766
Change subject: Remove static calls to MW code; this is a standalone lib!
......................................................................
Remove static calls to MW code; this is a standalone lib!
Change-Id: I70849a6ad37e5eb26fbee0453e02ad7888cd66d1
---
M includes/differ/MapDiffer.php
M includes/patcher/ThrowingPatcher.php
2 files changed, 0 insertions(+), 16 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Diff
refs/changes/66/56766/1
diff --git a/includes/differ/MapDiffer.php b/includes/differ/MapDiffer.php
index a8fa122..18cde1c 100644
--- a/includes/differ/MapDiffer.php
+++ b/includes/differ/MapDiffer.php
@@ -92,10 +92,6 @@
* @return DiffOp[]
*/
public function doDiff( array $oldValues, array $newValues ) {
- if ( function_exists( 'wfProfileIn' ) ) {
- wfProfileIn( __METHOD__ );
- }
-
$newSet = $this->array_diff_assoc( $newValues, $oldValues );
$oldSet = $this->array_diff_assoc( $oldValues, $newValues );
@@ -135,10 +131,6 @@
elseif ( $hasNew ) {
$diffSet[$key] = new DiffOpAdd( $newSet[$key] );
}
- }
-
- if ( function_exists( 'wfProfileOut' ) ) {
- wfProfileOut( __METHOD__ );
}
return $diffSet;
diff --git a/includes/patcher/ThrowingPatcher.php
b/includes/patcher/ThrowingPatcher.php
index c6a15ef..da0eb7a 100644
--- a/includes/patcher/ThrowingPatcher.php
+++ b/includes/patcher/ThrowingPatcher.php
@@ -90,10 +90,6 @@
* @return Diff
*/
public function getApplicableDiff( array $base, Diff $diff ) {
- if ( function_exists( 'wfProfileIn' ) ) {
- wfProfileIn( __METHOD__ );
- }
-
$throwErrors = $this->throwErrors;
$this->throwErrors = false;
@@ -108,10 +104,6 @@
$diffOps = $differ->doDiff( $base, $patched );
$diff = new Diff( $diffOps, $treatAsMap );
-
- if ( function_exists( 'wfProfileOut' ) ) {
- wfProfileOut( __METHOD__ );
- }
return $diff;
}
--
To view, visit https://gerrit.wikimedia.org/r/56766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I70849a6ad37e5eb26fbee0453e02ad7888cd66d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Diff
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
