Aaron Schulz has uploaded a new change for review.
https://gerrit.wikimedia.org/r/56776
Change subject: Added some TODO comments
......................................................................
Added some TODO comments
Change-Id: Ic79c9b709cac1df944377e568715bf2092d44c50
---
M WindowsAzureFileBackend.php
1 file changed, 4 insertions(+), 0 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WindowsAzureStorage
refs/changes/76/56776/1
diff --git a/WindowsAzureFileBackend.php b/WindowsAzureFileBackend.php
index 7f3fe7c..26af83f 100644
--- a/WindowsAzureFileBackend.php
+++ b/WindowsAzureFileBackend.php
@@ -355,6 +355,7 @@
}
try {
+ // @TODO: pass $metadata to addMissingMetadata() to
avoid round-trips
$this->addMissingMetadata( $srcCont, $srcRel,
$params['src'] );
$properties = $this->proxy->getBlobProperties(
$srcCont, $srcRel );
$timestamp =
$properties->getProperties()->getLastModified()->getTimestamp();
@@ -412,6 +413,8 @@
}
trigger_error( "Unable to set SHA-1 metadata for $path",
E_USER_WARNING );
// Set the SHA-1 metadata to 0 (setting to false doesn't seem
to work)
+ // @TODO: don't permanently set the object metadata here, just
make sure this PHP
+ // request doesn't keep trying to download the file
again and again.
$this->proxy->setBlobMetadata( $srcCont, $srcRel, array(
'sha1base36' => 0 ) );
wfProfileOut( __METHOD__ );
return false; // failed
@@ -481,6 +484,7 @@
if ( !empty( $params['topOnly'] ) ) {
// Blobs are listed in alphabetical order in
the response body, with
// upper-case letters listed first.
+ // @TODO: use prefix+delimeter here
$blobs = $this->proxy->listBlobs( $fullCont,
$options )->getBlobs();
foreach ( $blobs as $blob ) {
$name = $blob->getName();
--
To view, visit https://gerrit.wikimedia.org/r/56776
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic79c9b709cac1df944377e568715bf2092d44c50
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WindowsAzureStorage
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
