jenkins-bot has submitted this change and it was merged.
Change subject: Show the bottom toolbar without a scroll
......................................................................
Show the bottom toolbar without a scroll
Currently if the page has many messages, the bottom toolbar is
not visible till user scrolls(then it becomes floating)
Fix this by triggering a scroll event after messages loaded, to
make sure that toolbar is not inviisible initially
Change-Id: Ic284989e4bcfc8998e9dbee399f7797fe1a4b415
---
M resources/js/ext.translate.messagetable.js
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Amire80: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.messagetable.js
b/resources/js/ext.translate.messagetable.js
index b99457f..7d223b4 100644
--- a/resources/js/ext.translate.messagetable.js
+++ b/resources/js/ext.translate.messagetable.js
@@ -433,6 +433,8 @@
$( '.tux-messagetable-loader-more'
).text(
mw.msg(
'tux-messagetable-loading-messages', Math.min( remaining, pageSize ) )
);
+ // Make sure the floating toolbars are
visible without the need for scroll
+ $( window ).trigger( 'scroll' );
} )
.fail( function ( errorCode, response ) {
if ( response.error.code ===
'mctranslate-language-disabled' ) {
--
To view, visit https://gerrit.wikimedia.org/r/56575
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic284989e4bcfc8998e9dbee399f7797fe1a4b415
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
