Jdlrobson has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393651 )
Change subject: Clear spinner after window.print
......................................................................
Clear spinner after window.print
Looks like window.print may block so keep the spinner until
it's finished execution.
This may or may not fix the larger issue being discussed in the bug
but is harmless so why not.
Bug: T181261
Change-Id: I927d4bc8c96d74c14463f71b7ce6dec62618a485
---
M resources/skins.minerva.scripts/DownloadIcon.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/skins/MinervaNeue
refs/changes/51/393651/1
diff --git a/resources/skins.minerva.scripts/DownloadIcon.js
b/resources/skins.minerva.scripts/DownloadIcon.js
index 7f38aeb..5f9e3d2 100644
--- a/resources/skins.minerva.scripts/DownloadIcon.js
+++ b/resources/skins.minerva.scripts/DownloadIcon.js
@@ -46,8 +46,8 @@
function doPrint() {
self.timeout = clearTimeout( self.timeout );
- hideSpinner();
window.print();
+ hideSpinner();
}
// The click handler may be invoked multiple times so
if a pending print is occurring
--
To view, visit https://gerrit.wikimedia.org/r/393651
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I927d4bc8c96d74c14463f71b7ce6dec62618a485
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/skins/MinervaNeue
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
