Jforrester has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393688 )
Change subject: [WIP] HTMLForm: Drop this never-used backwards-compatibility
......................................................................
[WIP] HTMLForm: Drop this never-used backwards-compatibility
Change-Id: I6864d3a1207de44d465491baad87cb9c00714255
---
M RELEASE-NOTES-1.31
M includes/htmlform/fields/HTMLMultiSelectField.php
2 files changed, 5 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/88/393688/1
diff --git a/RELEASE-NOTES-1.31 b/RELEASE-NOTES-1.31
index 4b7795a..f1cb261 100644
--- a/RELEASE-NOTES-1.31
+++ b/RELEASE-NOTES-1.31
@@ -106,6 +106,10 @@
* Use of Maintenance::error( $err, $die ) to exit script was deprecated. Use
Maintenance::fatalError() instead.
* Passing a ParserOptions object to OutputPage::parserOptions() is deprecated.
+* The backwards-compatibility code in HTMLForm to add a drop-down control to an
+ option that is not set to be a drop-down if the "mw-chosen" class is present,
+ is now removed.
+* …
== Compatibility ==
MediaWiki 1.31 requires PHP 5.5.9 or later. There is experimental support for
diff --git a/includes/htmlform/fields/HTMLMultiSelectField.php
b/includes/htmlform/fields/HTMLMultiSelectField.php
index 238b2b4..21c034b 100644
--- a/includes/htmlform/fields/HTMLMultiSelectField.php
+++ b/includes/htmlform/fields/HTMLMultiSelectField.php
@@ -22,8 +22,7 @@
$this->mParams['disabled-options'] = [];
}
- // For backwards compatibility, also handle the old way with
'cssclass' => 'mw-chosen'
- if ( isset( $params['dropdown'] ) || strpos( $this->mClass,
'mw-chosen' ) !== false ) {
+ if ( isset( $params['dropdown'] ) ) {
$this->mClass .= ' mw-htmlform-dropdown';
}
--
To view, visit https://gerrit.wikimedia.org/r/393688
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6864d3a1207de44d465491baad87cb9c00714255
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
