jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/380791 )
Change subject: Enable MP3 audio transcodes by default
......................................................................
Enable MP3 audio transcodes by default
Currently TimedMediaHandler's frontend code doesn't work on the mobile
view, which means we don't load the ogv.js shim for Mobile Safari.
Creating MP3 transcodes for audio means they can get used directly
in the mobile view, fixing audio playback for iPhone/iPad and
probably Windows Mobile and other "misc" OSs.
Note that on desktop Safari/IE/Edge, ogv.js is still used because Ogg
has a higher priority than MP3. This may be changed later.
Relevant MP3 patents are believed to now be expired.
Bug: T165717
Change-Id: Ia06e3a3fe18628b378f786197da430515d9d92d3
---
M TimedMediaHandler.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/TimedMediaHandler.php b/TimedMediaHandler.php
index 0cade78..80b410d 100644
--- a/TimedMediaHandler.php
+++ b/TimedMediaHandler.php
@@ -225,7 +225,7 @@
// WebVideoTranscode::ENC_OGG_OPUS,
// avconv needs libmp3lame support
- // WebVideoTranscode::ENC_MP3,
+ WebVideoTranscode::ENC_MP3,
// avconv needs libvo_aacenc support
// WebVideoTranscode::ENC_AAC,
--
To view, visit https://gerrit.wikimedia.org/r/380791
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia06e3a3fe18628b378f786197da430515d9d92d3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <br...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
