jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/390363 )
Change subject: Replace repetitive comment about breakpoint values with single
one
......................................................................
Replace repetitive comment about breakpoint values with single one
Change-Id: Id92c426ebd3bb0f4c1a81c7f4be87a51e2ccffee
---
M wikimedia-ui-base.css
M wikimedia-ui-base.less
2 files changed, 9 insertions(+), 28 deletions(-)
Approvals:
jenkins-bot: Verified
VolkerE: Looks good to me, approved
diff --git a/wikimedia-ui-base.css b/wikimedia-ui-base.css
index 10ca2ce..3209a8b 100644
--- a/wikimedia-ui-base.css
+++ b/wikimedia-ui-base.css
@@ -5,36 +5,28 @@
:root {
/* == Breakpoints == */
+ /* The following numbers are prone to change with new information. */
+
/**
* Minimum available screen width at which a device can be considered a
mobile device
* Many older feature phones have screens smaller than this value.
- * Number is prone to change with new information.
*/
--width-breakpoint-mobile: 320px;
/**
* Minimum available screen width at which a device can be considered a
tablet
* The number is currently based on the device width of a Samsung
Galaxy S5 mini and is low
- * enough to cover iPad (768px). Number is prone to change with new
information.
+ * enough to cover iPad (768px).
*/
--width-breakpoint-tablet: 720px;
- /**
- * Minimum available screen width at which a device can be considered a
desktop
- * Number is prone to change with new information.
- */
+ /* Minimum available screen width at which a device can be considered a
desktop */
--width-breakpoint-desktop: 1000px;
- /**
- * Wider desktop breakpoint, currently used in Flow.
- * Number is prone to change with new information.
- */
+ /* Wider desktop breakpoint, currently used in Flow. */
--width-breakpoint-desktop-wide: 1200px;
- /**
- * Extra wide desktop breakpoint
- * Number is prone to change with new information.
- */
+ /* Extra wide desktop breakpoint */
--width-breapoint-desktop-extrawide: 2000px;
diff --git a/wikimedia-ui-base.less b/wikimedia-ui-base.less
index 7976e62..572013b 100644
--- a/wikimedia-ui-base.less
+++ b/wikimedia-ui-base.less
@@ -4,35 +4,24 @@
*/
// == Breakpoints ==
+// The following numbers are prone to change with new information.
+
// Minimum available screen width at which a device can be considered a mobile
device
// Many older feature phones have screens smaller than this value.
-// Number is prone to change with new information.
-
@width-breakpoint-mobile: 320px;
-
// Minimum available screen width at which a device can be considered a tablet
// The number is currently based on the device width of a Samsung Galaxy S5
mini and is low
-// enough to cover iPad (768px). Number is prone to change with new
information.
-
+// enough to cover iPad (768px).
@width-breakpoint-tablet: 720px;
-
// Minimum available screen width at which a device can be considered a desktop
-// Number is prone to change with new information.
-
@width-breakpoint-desktop: 1000px;
-
// Wider desktop breakpoint, currently used in Flow.
-// Number is prone to change with new information.
-
@width-breakpoint-desktop-wide: 1200px;
-
// Extra wide desktop breakpoint
-// Number is prone to change with new information.
-
@width-breapoint-desktop-extrawide: 2000px;
--
To view, visit https://gerrit.wikimedia.org/r/390363
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id92c426ebd3bb0f4c1a81c7f4be87a51e2ccffee
Gerrit-PatchSet: 3
Gerrit-Project: wikimedia-ui-base
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: VolkerE <volke...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
