jenkins-bot has submitted this change and it was merged.
Change subject: Fix errors reported by phpcs in includes/HTMLForm.php
......................................................................
Fix errors reported by phpcs in includes/HTMLForm.php
I set property "$typeMappings" to private (no clients outside this class
in our codebase).
I removed property $jsAdded, it is unused in this class and throughout
the codebase and seems a leftover from 2008.
Special:Preferences still works with this change.
Change-Id: Id5668141835e22e3e1b043109e50d73ccd6b1229
---
M includes/HTMLForm.php
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Alex Monk: Looks good to me, approved
Umherirrender: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/HTMLForm.php b/includes/HTMLForm.php
index 4a527bb..816ea16 100644
--- a/includes/HTMLForm.php
+++ b/includes/HTMLForm.php
@@ -95,7 +95,7 @@
class HTMLForm extends ContextSource {
// A mapping of 'type' inputs onto standard HTMLFormField subclasses
- static $typeMappings = array(
+ private static $typeMappings = array(
'api' => 'HTMLApiField',
'text' => 'HTMLTextField',
'textarea' => 'HTMLTextAreaField',
@@ -1996,7 +1996,6 @@
* Select dropdown field, with an additional "other" textbox.
*/
class HTMLSelectOrOtherField extends HTMLTextField {
- static $jsAdded = false;
function __construct( $params ) {
if ( !in_array( 'other', $params['options'], true ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/56078
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5668141835e22e3e1b043109e50d73ccd6b1229
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Spage <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Reedy <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
