jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/392513 )
Change subject: Add an overflow menu option in Feed cards to go to the
Configure screen
......................................................................
Add an overflow menu option in Feed cards to go to the Configure screen
Bug: T180843
Change-Id: I5eb18bd0c8567eeb3ca6e550829ce004765432ce
---
M app/src/main/java/org/wikipedia/feed/FeedFragment.java
M app/src/main/java/org/wikipedia/feed/view/CardHeaderView.java
M app/src/main/java/org/wikipedia/feed/view/StaticCardView.java
M app/src/main/res/menu/menu_feed_card_header.xml
4 files changed, 18 insertions(+), 0 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
index f1c939b..60e7f8c 100644
--- a/app/src/main/java/org/wikipedia/feed/FeedFragment.java
+++ b/app/src/main/java/org/wikipedia/feed/FeedFragment.java
@@ -397,6 +397,11 @@
}
@Override
+ public void onRequestCustomize() {
+ showConfigureActivity();
+ }
+
+ @Override
public void onSwiped(@IntRange(from = 0) int itemPos) {
onRequestDismissCard(coordinator.getCards().get(itemPos));
}
diff --git a/app/src/main/java/org/wikipedia/feed/view/CardHeaderView.java
b/app/src/main/java/org/wikipedia/feed/view/CardHeaderView.java
index 0b4cc49..1369253 100644
--- a/app/src/main/java/org/wikipedia/feed/view/CardHeaderView.java
+++ b/app/src/main/java/org/wikipedia/feed/view/CardHeaderView.java
@@ -28,6 +28,7 @@
public class CardHeaderView extends ConstraintLayout {
public interface Callback {
boolean onRequestDismissCard(@NonNull Card card);
+ void onRequestCustomize();
}
@BindView(R.id.view_card_header_image) AppCompatImageView imageView;
@@ -119,6 +120,11 @@
return callback.onRequestDismissCard(card);
}
return false;
+ case R.id.menu_feed_card_customize:
+ if (callback != null) {
+ callback.onRequestCustomize();
+ }
+ return true;
default:
return false;
}
diff --git a/app/src/main/java/org/wikipedia/feed/view/StaticCardView.java
b/app/src/main/java/org/wikipedia/feed/view/StaticCardView.java
index 125cfff..a50cdaf 100644
--- a/app/src/main/java/org/wikipedia/feed/view/StaticCardView.java
+++ b/app/src/main/java/org/wikipedia/feed/view/StaticCardView.java
@@ -93,6 +93,11 @@
return getCallback().onRequestDismissCard(getCard());
}
return false;
+ case R.id.menu_feed_card_customize:
+ if (getCallback() != null) {
+ getCallback().onRequestCustomize();
+ }
+ return true;
default:
return false;
}
diff --git a/app/src/main/res/menu/menu_feed_card_header.xml
b/app/src/main/res/menu/menu_feed_card_header.xml
index f33e069..b592015 100644
--- a/app/src/main/res/menu/menu_feed_card_header.xml
+++ b/app/src/main/res/menu/menu_feed_card_header.xml
@@ -3,4 +3,6 @@
<menu xmlns:android="http://schemas.android.com/apk/res/android";>
<item android:id="@+id/menu_feed_card_dismiss"
android:title="@string/menu_feed_card_dismiss"/>
+ <item android:id="@+id/menu_feed_card_customize"
+ android:title="@string/feed_configure_activity_title"/>
</menu>
--
To view, visit https://gerrit.wikimedia.org/r/392513
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5eb18bd0c8567eeb3ca6e550829ce004765432ce
Gerrit-PatchSet: 3
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Cooltey <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
