Petar.petkovic has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393901 )
Change subject: Fix null reference error on discard translation
......................................................................
Fix null reference error on discard translation
- Add additional check before trying to remove class from
translation list item action trigger.
- Without checking, we get null reference error when user
opens actions menu (only when opened on hover) on
translation list item and clicks "Discard translation".
- Introduced in I52b0e0b8f681de91673e1e6eccea564b72fde0b4.
Bug: T181533
Change-Id: I4a4223863a0bd8de4068e658d006d8bfc0cafb78
---
M modules/dashboard/ext.cx.translationlist.js
1 file changed, 3 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation
refs/changes/01/393901/1
diff --git a/modules/dashboard/ext.cx.translationlist.js
b/modules/dashboard/ext.cx.translationlist.js
index 0c7dda9..bb557c5 100644
--- a/modules/dashboard/ext.cx.translationlist.js
+++ b/modules/dashboard/ext.cx.translationlist.js
@@ -468,7 +468,9 @@
e.stopPropagation();
translation = $( this ).closest( '.cx-tlitem' ).data(
'translation' );
- self.$selectedActionMenu.removeClass(
'cx-tlitem__actions--selected' );
+ if ( self.$selectedActionMenu ) {
+ self.$selectedActionMenu.removeClass(
'cx-tlitem__actions--selected' );
+ }
OO.ui.getWindowManager().openWindow( 'message',
$.extend( {
message: mw.msg(
'cx-draft-discard-confirmation-message' ),
--
To view, visit https://gerrit.wikimedia.org/r/393901
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a4223863a0bd8de4068e658d006d8bfc0cafb78
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Petar.petkovic <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
