Jforrester has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393957 )
Change subject: Update OOjs UI to v0.24.3 ...................................................................... Update OOjs UI to v0.24.3 Release notes: https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md;v0.24.3 Change-Id: Ifdd44ead7d782288aaef0979322f0943f7304853 --- M composer.json M composer.lock M composer/installed.json M oojs/oojs-ui/History.md M oojs/oojs-ui/README.md M oojs/oojs-ui/bin/testsuitegenerator.rb M oojs/oojs-ui/demos/demo.js M oojs/oojs-ui/i18n/lv.json M oojs/oojs-ui/i18n/sl.json M oojs/oojs-ui/i18n/sr-ec.json M oojs/oojs-ui/i18n/sr-el.json M oojs/oojs-ui/i18n/ur.json M oojs/oojs-ui/package.json M oojs/oojs-ui/php/widgets/TextInputWidget.php 14 files changed, 173 insertions(+), 104 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vendor refs/changes/57/393957/1 diff --git a/composer.json b/composer.json index d90bc77..0a7f405 100644 --- a/composer.json +++ b/composer.json @@ -83,7 +83,7 @@ "mustangostang/spyc": "0.6.2", "nikic/php-parser": "3.0.6", "nmred/kafka-php": "0.1.5", - "oojs/oojs-ui": "0.24.2", + "oojs/oojs-ui": "0.24.3", "oyejorge/less.php": "1.7.0.14", "pear/console_getopt": "1.4.1", "pear/mail": "1.4.1", diff --git a/composer.lock b/composer.lock index 7a7e842..ad4345b 100644 --- a/composer.lock +++ b/composer.lock @@ -4,7 +4,7 @@ "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#composer-lock-the-lock-file";, "This file is @generated automatically" ], - "content-hash": "27b864cad3750d7557cd5dae84899c82", + "content-hash": "e948033dcea38ac3c205abf7e2e274f7", "packages": [ { "name": "composer/semver", @@ -1245,16 +1245,16 @@ }, { "name": "oojs/oojs-ui", - "version": "v0.24.2", + "version": "v0.24.3", "source": { "type": "git", "url": "https://github.com/wikimedia/oojs-ui.git";, - "reference": "b6d9d5e50940a7c56d329a605c64d51f147aab80" + "reference": "a48d69b22bf89b87f2f931a4c23401e6214562d4" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/wikimedia/oojs-ui/zipball/b6d9d5e50940a7c56d329a605c64d51f147aab80";, - "reference": "b6d9d5e50940a7c56d329a605c64d51f147aab80", + "url": "https://api.github.com/repos/wikimedia/oojs-ui/zipball/a48d69b22bf89b87f2f931a4c23401e6214562d4";, + "reference": "a48d69b22bf89b87f2f931a4c23401e6214562d4", "shasum": "" }, "require": { @@ -1320,7 +1320,7 @@ ], "description": "Provides library of common widgets, layouts, and windows.", "homepage": "https://www.mediawiki.org/wiki/OOjs_UI";, - "time": "2017-11-07T21:27:09+00:00" + "time": "2017-11-28T23:14:25+00:00" }, { "name": "oyejorge/less.php", diff --git a/composer/installed.json b/composer/installed.json index 10d56f4..c031f43 100644 --- a/composer/installed.json +++ b/composer/installed.json @@ -3205,87 +3205,6 @@ ] }, { - "name": "oojs/oojs-ui", - "version": "v0.24.2", - "version_normalized": "0.24.2.0", - "source": { - "type": "git", - "url": "https://github.com/wikimedia/oojs-ui.git";, - "reference": "b6d9d5e50940a7c56d329a605c64d51f147aab80" - }, - "dist": { - "type": "zip", - "url": "https://api.github.com/repos/wikimedia/oojs-ui/zipball/b6d9d5e50940a7c56d329a605c64d51f147aab80";, - "reference": "b6d9d5e50940a7c56d329a605c64d51f147aab80", - "shasum": "" - }, - "require": { - "mediawiki/at-ease": "1.1.0", - "php": ">=5.5.9" - }, - "require-dev": { - "jakub-onderka/php-parallel-lint": "0.9.2", - "mediawiki/mediawiki-codesniffer": "14.1.0", - "phpunit/phpunit": "4.8.21" - }, - "time": "2017-11-07T21:27:09+00:00", - "type": "library", - "installation-source": "dist", - "autoload": { - "classmap": [ - "php/" - ] - }, - "notification-url": "https://packagist.org/downloads/";, - "license": [ - "MIT" - ], - "authors": [ - { - "name": "Timo Tijhof", - "email": "[email protected]" - }, - { - "name": "Bartosz Dziewoński", - "email": "[email protected]" - }, - { - "name": "Ed Sanders", - "email": "[email protected]" - }, - { - "name": "James D. Forrester", - "email": "[email protected]" - }, - { - "name": "Kirsten Menger-Anderson", - "email": "[email protected]" - }, - { - "name": "Rob Moen", - "email": "[email protected]" - }, - { - "name": "Roan Kattouw", - "email": "[email protected]" - }, - { - "name": "Trevor Parscal", - "email": "[email protected]" - }, - { - "name": "Kunal Mehta", - "email": "[email protected]" - }, - { - "name": "Prateek Saxena", - "email": "[email protected]" - } - ], - "description": "Provides library of common widgets, layouts, and windows.", - "homepage": "https://www.mediawiki.org/wiki/OOjs_UI"; - }, - { "name": "wikibase/data-model", "version": "7.3.0", "version_normalized": "7.3.0.0", @@ -3834,5 +3753,86 @@ "json", "schema" ] + }, + { + "name": "oojs/oojs-ui", + "version": "v0.24.3", + "version_normalized": "0.24.3.0", + "source": { + "type": "git", + "url": "https://github.com/wikimedia/oojs-ui.git";, + "reference": "a48d69b22bf89b87f2f931a4c23401e6214562d4" + }, + "dist": { + "type": "zip", + "url": "https://api.github.com/repos/wikimedia/oojs-ui/zipball/a48d69b22bf89b87f2f931a4c23401e6214562d4";, + "reference": "a48d69b22bf89b87f2f931a4c23401e6214562d4", + "shasum": "" + }, + "require": { + "mediawiki/at-ease": "1.1.0", + "php": ">=5.5.9" + }, + "require-dev": { + "jakub-onderka/php-parallel-lint": "0.9.2", + "mediawiki/mediawiki-codesniffer": "14.1.0", + "phpunit/phpunit": "4.8.21" + }, + "time": "2017-11-28T23:14:25+00:00", + "type": "library", + "installation-source": "dist", + "autoload": { + "classmap": [ + "php/" + ] + }, + "notification-url": "https://packagist.org/downloads/";, + "license": [ + "MIT" + ], + "authors": [ + { + "name": "Timo Tijhof", + "email": "[email protected]" + }, + { + "name": "Bartosz Dziewoński", + "email": "[email protected]" + }, + { + "name": "Ed Sanders", + "email": "[email protected]" + }, + { + "name": "James D. Forrester", + "email": "[email protected]" + }, + { + "name": "Kirsten Menger-Anderson", + "email": "[email protected]" + }, + { + "name": "Rob Moen", + "email": "[email protected]" + }, + { + "name": "Roan Kattouw", + "email": "[email protected]" + }, + { + "name": "Trevor Parscal", + "email": "[email protected]" + }, + { + "name": "Kunal Mehta", + "email": "[email protected]" + }, + { + "name": "Prateek Saxena", + "email": "[email protected]" + } + ], + "description": "Provides library of common widgets, layouts, and windows.", + "homepage": "https://www.mediawiki.org/wiki/OOjs_UI"; } ] diff --git a/oojs/oojs-ui/History.md b/oojs/oojs-ui/History.md index 1ee8904..c9f9787 100644 --- a/oojs/oojs-ui/History.md +++ b/oojs/oojs-ui/History.md @@ -1,4 +1,30 @@ # OOjs UI Release History +## v0.24.3 / 2017-11-28 +### Features +* Allow adding virtual viewport spacing (Bartosz Dziewoński) +* ClippableElement: Allow clipping with top or left edge (Bartosz Dziewoński) +* DropdownInputWidget: Generate a hidden `<select>` in JS (Bartosz Dziewoński) +* FieldsetLayout: Hide header when there is no icon or label (Bartosz Dziewoński) +* MenuSelectWidget, PopupWidget: Automatically change popup direction if there is no space (Bartosz Dziewoński) +* PopupToolGroup: Set clipping edges to fix clipping edge (heh) cases (Bartosz Dziewoński) +* TextInputWidget: support spellcheck attribute (David Lynch) + +### Styles +* themes: Fix PHP ComboboxInputWidget indicator position (Volker E.) +* WikimediaUI theme: Restore `:hover:focus` border color on TextInputWidgets (Volker E.) +* oo-ui-background-image: Drop `-o-linear-gradient` fallback (James D. Forrester) +* oo-ui-background-image: Drop `-webkit-linear-gradient` fallback (James D. Forrester) + +### Code +* PHP DropdownInputWidget: Workaround for Firefox 57 ignoring attr selector with whitespace (Volker E.) +* DraggableGroupElement: Don't try to access non-existent property (Bartosz Dziewoński) +* DropdownInputWidget: Remove duplicate TitledElement mixin (Bartosz Dziewoński) +* README: Add "Community" section (Prateek Saxena) +* README: Re-arrange intro section (Prateek Saxena) +* build: Bump wikimedia-ui-base (Volker E.) +* git.wikimedia.org -> phab (Zach) + + ## v0.24.2 / 2017-11-07 ### Deprecations * [DEPRECATING CHANGE] Use en-US spelling for icon names for consistency (Ed Sanders) diff --git a/oojs/oojs-ui/README.md b/oojs/oojs-ui/README.md index de5ac94..f10330f 100644 --- a/oojs/oojs-ui/README.md +++ b/oojs/oojs-ui/README.md @@ -3,7 +3,16 @@ OOjs UI ================= -OOjs UI is a modern JavaScript UI library. It provides common widgets, layouts, dialogs and icons that are ready to use, as well as many useful and convenient classes for constructing custom user interfaces. It is the standard user-interface library in Wikimedia Foundation Web products, having been originally created for use by [VisualEditor](https://www.mediawiki.org/wiki/VisualEditor), which uses it for its entire user interface. +OOjs UI is a component-based JavaScript UI library. Key features: + +* Common widgets, layouts, and dialogs +* Classes, elements, and mixins to create custom interfaces +* Internationalization and localization, like right-to-left (RTL) languages support +* Theme-ability +* Built-in icons +* Accessibility features + +It is the standard library for Web products at the Wikimedia Foundation, having been originally created for use by [VisualEditor](https://www.mediawiki.org/wiki/VisualEditor). Quick start @@ -78,6 +87,16 @@ A new version of the library is released most weeks on Tuesdays. +Community +--------- + +Get updates, ask questions and join the discussion with maintainers and contributors: + +* Join the Wikimedia Developers mailing list, [wikitech-l](https://lists.wikimedia.org/mailman/listinfo/wikitech-l). +* Chat with the maintainers on `#wikimedia-dev` on `irc.freenode.net`. +* Ask questions on [StackOverflow](https://stackoverflow.com/tags/oojs-ui/info). +* Watchlist the [documentation](https://www.mediawiki.org/wiki/OOjs_UI) on MediaWiki to stay updated. + Versioning ---------- diff --git a/oojs/oojs-ui/bin/testsuitegenerator.rb b/oojs/oojs-ui/bin/testsuitegenerator.rb index 5c7da37..c4ef5db 100644 --- a/oojs/oojs-ui/bin/testsuitegenerator.rb +++ b/oojs/oojs-ui/bin/testsuitegenerator.rb @@ -16,7 +16,7 @@ # classes with different PHP and JS implementations. # we can still compare the PHP-infuse result to JS result, though. - infuse_only_classes = %w[DropdownInputWidget ComboBoxInputWidget + infuse_only_classes = %w[ComboBoxInputWidget RadioSelectInputWidget CheckboxMultiselectInputWidget] testable_classes = classes .reject{|c| c[:abstract] } # can't test abstract classes diff --git a/oojs/oojs-ui/demos/demo.js b/oojs/oojs-ui/demos/demo.js index c41e6c0..9ee3e12 100644 --- a/oojs/oojs-ui/demos/demo.js +++ b/oojs/oojs-ui/demos/demo.js @@ -29,7 +29,10 @@ new OO.ui.MenuOptionWidget( { data: 'icons', label: 'Icons' } ), new OO.ui.MenuOptionWidget( { data: 'toolbars', label: 'Toolbars' } ), new OO.ui.MenuOptionWidget( { data: 'widgets', label: 'Widgets' } ) - ] + ], + // Funny effect... This dropdown is considered to always be "out of viewport" + // due to the getViewportSpacing() override below. Don't let it disappear. + hideWhenOutOfView: false }, classes: [ 'demo-pageDropdown' ] } ); @@ -99,6 +102,15 @@ OO.ui.isMobile = function () { return demo.mode.platform === 'mobile'; }; + OO.ui.getViewportSpacing = function () { + return { + // Contents of dialogs are shown on top of the fixed menu + top: demo.mode.page === 'dialogs' ? 0 : demo.$menu.outerHeight(), + right: 0, + bottom: 0, + left: 0 + }; + }; }; /* Setup */ diff --git a/oojs/oojs-ui/i18n/lv.json b/oojs/oojs-ui/i18n/lv.json index 74658ce..6423c75 100644 --- a/oojs/oojs-ui/i18n/lv.json +++ b/oojs/oojs-ui/i18n/lv.json @@ -14,6 +14,7 @@ "ooui-toolbar-more": "Vairāk", "ooui-toolgroup-expand": "Vairāk", "ooui-toolgroup-collapse": "Mazāk", + "ooui-item-remove": "Noņemt", "ooui-dialog-message-accept": "Labi", "ooui-dialog-message-reject": "Atcelt", "ooui-dialog-process-error": "Kaut kas nogāja greizi", diff --git a/oojs/oojs-ui/i18n/sl.json b/oojs/oojs-ui/i18n/sl.json index 1b481a3..8e79e94 100644 --- a/oojs/oojs-ui/i18n/sl.json +++ b/oojs/oojs-ui/i18n/sl.json @@ -13,6 +13,7 @@ "ooui-toolbar-more": "Več", "ooui-toolgroup-expand": "Več", "ooui-toolgroup-collapse": "Manj", + "ooui-item-remove": "Odstrani", "ooui-dialog-message-accept": "V redu", "ooui-dialog-message-reject": "Prekliči", "ooui-dialog-process-error": "Nekaj je šlo narobe", diff --git a/oojs/oojs-ui/i18n/sr-ec.json b/oojs/oojs-ui/i18n/sr-ec.json index 6d675da..de1ee47 100644 --- a/oojs/oojs-ui/i18n/sr-ec.json +++ b/oojs/oojs-ui/i18n/sr-ec.json @@ -25,5 +25,5 @@ "ooui-selectfile-button-select": "Изабери датотеку", "ooui-selectfile-not-supported": "Избор датотеке није подржан", "ooui-selectfile-placeholder": "Није изабрана ниједна датотека", - "ooui-selectfile-dragdrop-placeholder": "Додајте датотеку овде" + "ooui-selectfile-dragdrop-placeholder": "Превуците датотеку овде" } diff --git a/oojs/oojs-ui/i18n/sr-el.json b/oojs/oojs-ui/i18n/sr-el.json index bdf6a64..cd286e8 100644 --- a/oojs/oojs-ui/i18n/sr-el.json +++ b/oojs/oojs-ui/i18n/sr-el.json @@ -1,7 +1,8 @@ { "@metadata": { "authors": [ - "Milicevic01" + "Milicevic01", + "Prevodim" ] }, "ooui-outline-control-move-down": "Premesti stavku na dole", @@ -10,6 +11,7 @@ "ooui-toolbar-more": "Više", "ooui-toolgroup-expand": "Više", "ooui-toolgroup-collapse": "Manje", + "ooui-item-remove": "Ukloni", "ooui-dialog-message-accept": "U redu", "ooui-dialog-message-reject": "Otkaži", "ooui-dialog-process-error": "Nešto je pošlo naopako", @@ -17,5 +19,7 @@ "ooui-dialog-process-retry": "Pokušaj ponovo", "ooui-dialog-process-continue": "Nastavi", "ooui-selectfile-button-select": "Izaberi datoteku", - "ooui-selectfile-placeholder": "Nije izabrana nijedna datoteka" + "ooui-selectfile-not-supported": "Odabir datoteke nije podržan", + "ooui-selectfile-placeholder": "Nije izabrana nijedna datoteka", + "ooui-selectfile-dragdrop-placeholder": "Prevuci datoteku ovde" } diff --git a/oojs/oojs-ui/i18n/ur.json b/oojs/oojs-ui/i18n/ur.json index ce0235c..d450ceb 100644 --- a/oojs/oojs-ui/i18n/ur.json +++ b/oojs/oojs-ui/i18n/ur.json @@ -1,24 +1,25 @@ { "@metadata": { "authors": [ - "Muhammad Shuaib" + "Muhammad Shuaib", + "Zainab Meher" ] }, - "ooui-outline-control-move-down": "آئیٹم نیچے کھسکائیں", - "ooui-outline-control-move-up": "آئیٹم اوپر بڑھائیں", - "ooui-outline-control-remove": "آئیٹم حذف کریں", + "ooui-outline-control-move-down": "مد نیچے کھسکائیں", + "ooui-outline-control-move-up": " مداوپرلےجائیں", + "ooui-outline-control-remove": " مدحذف کریں", "ooui-toolbar-more": "مزید", "ooui-toolgroup-expand": "مزید", "ooui-toolgroup-collapse": "کم کریں", - "ooui-item-remove": "حذف کریں", + "ooui-item-remove": "ھٹادیں", "ooui-dialog-message-accept": "ٹھیک", - "ooui-dialog-message-reject": "منسوخ کریں", + "ooui-dialog-message-reject": "حزف کریں", "ooui-dialog-process-error": "کچھ غلط ہو گیا ہے", - "ooui-dialog-process-dismiss": "ختم کریں", + "ooui-dialog-process-dismiss": "موقوف کریں", "ooui-dialog-process-retry": "دوبارہ کوشش کریں", "ooui-dialog-process-continue": "جاری رکھیں", "ooui-selectfile-button-select": "فائل منتخب کریں", "ooui-selectfile-not-supported": "فائل کا انتخاب معاونت شدہ نہیں", - "ooui-selectfile-placeholder": "کوئی فائل منتخب نہیں", + "ooui-selectfile-placeholder": "کوئی فائل منتخب نہیں کی گئ", "ooui-selectfile-dragdrop-placeholder": "فائل یہاں چھوڑیں" } diff --git a/oojs/oojs-ui/package.json b/oojs/oojs-ui/package.json index fe90f39..0e10483 100644 --- a/oojs/oojs-ui/package.json +++ b/oojs/oojs-ui/package.json @@ -1,6 +1,6 @@ { "name": "oojs-ui", - "version": "0.24.2", + "version": "0.24.3", "description": "User interface classes built on the OOjs framework.", "keywords": [ "oojs-plugin", @@ -25,7 +25,7 @@ "dependencies": { "jquery": "3.2.1", "oojs": "2.1.0", - "wikimedia-ui-base": "0.9.2" + "wikimedia-ui-base": "0.10.0" }, "devDependencies": { "eslint-config-wikimedia": "0.5.0", diff --git a/oojs/oojs-ui/php/widgets/TextInputWidget.php b/oojs/oojs-ui/php/widgets/TextInputWidget.php index 72abc16..14e68f6 100644 --- a/oojs/oojs-ui/php/widgets/TextInputWidget.php +++ b/oojs/oojs-ui/php/widgets/TextInputWidget.php @@ -58,6 +58,8 @@ * Implies `indicator: 'required'`. (default: false) * @param bool $config['autocomplete'] If the field should support autocomplete * or not (default: true) + * @param bool $config['spellcheck'] If the field should support spellcheck + * or not (default: browser-dependent) */ public function __construct( array $config = [] ) { // Config initialization @@ -120,6 +122,9 @@ if ( !$config['autocomplete'] ) { $this->input->setAttributes( [ 'autocomplete' => 'off' ] ); } + if ( isset( $config['spellcheck'] ) ) { + $this->input->setAttributes( [ 'spellcheck' => $config['spellcheck'] ? 'true' : 'false' ] ); + } if ( $this->multiline && isset( $config['rows'] ) && $config['rows'] ) { $this->input->setAttributes( [ 'rows' => $config['rows'] ] ); } -- To view, visit https://gerrit.wikimedia.org/r/393957 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ifdd44ead7d782288aaef0979322f0943f7304853 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/vendor Gerrit-Branch: master Gerrit-Owner: Jforrester <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
