jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/393945 )

Change subject: Cache anti-stampede improvements
......................................................................


Cache anti-stampede improvements

Should prevent cache update race conditions.

Bug: T181567
Change-Id: I7d472cc23a45fd0a1c134b369ccd671cc1d5acee
---
M includes/Stats.php
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
  jenkins-bot: Verified
  Halfak: Looks good to me, approved



diff --git a/includes/Stats.php b/includes/Stats.php
index 777fb2c..2b9922b 100644
--- a/includes/Stats.php
+++ b/includes/Stats.php
@@ -113,7 +113,13 @@
                                                $ttl = 
WANObjectCache::TTL_MINUTE;
                                                return [];
                                        }
-                               }
+                               },
+                               [
+                                       // Try to only let one datacenter 
thread manage cache updates at a time
+                                       'lockTSE' => 10,
+                                       // Avoid querying cache servers 
multiple times in a web request
+                                       'pcTTL' => 
WANObjectCache::TTL_PROC_LONG,
+                               ]
                        );
                        return $result;
                } else {

-- 
To view, visit https://gerrit.wikimedia.org/r/393945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7d472cc23a45fd0a1c134b369ccd671cc1d5acee
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/ORES
Gerrit-Branch: master
Gerrit-Owner: Awight <[email protected]>
Gerrit-Reviewer: Halfak <[email protected]>
Gerrit-Reviewer: Krinkle <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to