Phantom42 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394029 )

Change subject: Migrate to BaseTemplateToolbox hook
......................................................................

Migrate to BaseTemplateToolbox hook

Bug: T178699
Change-Id: I463d45fb0d2604259732a7e4fea9e80d4a144b13
---
M Translate.php
M utils/ToolBox.php
2 files changed, 8 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate 
refs/changes/29/394029/1

diff --git a/Translate.php b/Translate.php
index 34579bf..ec872bd 100644
--- a/Translate.php
+++ b/Translate.php
@@ -134,7 +134,7 @@
 $wgHooks['SpecialRecentChangesPanel'][] = 
'TranslateRcFilter::translationFilterForm';
 $wgHooks['ChangesListSpecialPageStructuredFilters'][] =
        'TranslateRcFilter::onChangesListSpecialPageStructuredFilters';
-$wgHooks['SkinTemplateToolboxEnd'][] = 
'TranslateToolbox::toolboxAllTranslations';
+$wgHooks['BaseTemplateToolbox'][] = 'TranslateToolbox::toolboxAllTranslations';
 $wgHooks['AbortEmailNotification'][] = 
'TranslateHooks::onAbortEmailNotificationReview';
 
 // Translation memory related
diff --git a/utils/ToolBox.php b/utils/ToolBox.php
index 3388a65..30c4113 100644
--- a/utils/ToolBox.php
+++ b/utils/ToolBox.php
@@ -22,18 +22,20 @@
         *
         * @return bool
         */
-       public static function toolboxAllTranslations( &$quickTemplate ) {
-               $title = $quickTemplate->getSkin()->getTitle();
+       public static function toolboxAllTranslations( $baseTemplate, &$toolbox 
) {
+               $title = $baseTemplate->getSkin()->getTitle();
                $handle = new MessageHandle( $title );
                if ( $handle->isValid() ) {
                        $message = $title->getNsText() . ':' . 
$handle->getKey();
-                       $desc = wfMessage( 'translate-sidebar-alltrans' 
)->escaped();
                        $url = htmlspecialchars( SpecialPage::getTitleFor( 
'Translations' )
                                ->getLocalURL( [ 'message' => $message ] ) );
 
                        // Add the actual toolbox entry.
-                       // Add newlines and tabs for nicer HTML output.
-                       echo "\n\t\t\t\t<li id=\"t-alltrans\"><a 
href=\"$url\">$desc</a></li>\n";
+                       $toolbox[ 'alltrans' ] = array(
+                               'href' => $url,
+                               'id' => 't-alltrans',
+                               'msg' => 'translate-sidebar-alltrans',
+                       );
                }
 
                return true;

-- 
To view, visit https://gerrit.wikimedia.org/r/394029
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I463d45fb0d2604259732a7e4fea9e80d4a144b13
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Phantom42 <nikita...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to