jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/393926 )
Change subject: roundtrip-test.js: Strip section tags before comparing DOMs
......................................................................
roundtrip-test.js: Strip section tags before comparing DOMs
Since we don't add DSR info on section tags, they can trip up
roundtrip-test.js error classification code.
This fixes the odd behavior we saw where a vast majority of semantic
errors got classified as syntactic errors.
Change-Id: Iec1d42f7cd943388efc4c4d7d22efd346e8944d8
---
M bin/roundtrip-test.js
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Subramanya Sastry: Looks good to me, approved
C. Scott Ananian: Looks good to me, approved
jenkins-bot: Verified
diff --git a/bin/roundtrip-test.js b/bin/roundtrip-test.js
index f3280c6..2f97dda 100755
--- a/bin/roundtrip-test.js
+++ b/bin/roundtrip-test.js
@@ -392,6 +392,10 @@
stripElementIds(oldBody.ownerDocument.body);
stripElementIds(newBody.ownerDocument.body);
+ // Strip section tags from the DOMs
+ DU.stripSectionTags(oldBody.ownerDocument.body);
+ DU.stripSectionTags(newBody.ownerDocument.body);
+
var i, offset;
var results = [];
// Use the full tests for fostered content.
--
To view, visit https://gerrit.wikimedia.org/r/393926
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iec1d42f7cd943388efc4c4d7d22efd346e8944d8
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: Arlolra <[email protected]>
Gerrit-Reviewer: C. Scott Ananian <[email protected]>
Gerrit-Reviewer: Sbailey <[email protected]>
Gerrit-Reviewer: Subramanya Sastry <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
