Eileen has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394220 )
Change subject: Comment block tidy ups
......................................................................
Comment block tidy ups
Change-Id: I74cee89622b2dd7588534de5791dd1110538277a
---
M sites/all/modules/offline2civicrm/ChecksFile.php
1 file changed, 13 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/crm
refs/changes/20/394220/1
diff --git a/sites/all/modules/offline2civicrm/ChecksFile.php
b/sites/all/modules/offline2civicrm/ChecksFile.php
index 74fa25c..4d6601a 100644
--- a/sites/all/modules/offline2civicrm/ChecksFile.php
+++ b/sites/all/modules/offline2civicrm/ChecksFile.php
@@ -24,6 +24,8 @@
protected $all_missed_file_uri = '';
+ protected $row_index;
+
/**
* @var resource
*/
@@ -221,9 +223,11 @@
/**
* Read a row and transform into normalized queue message form
*
- * @param array $row native format for this upload file, usually a dict
+ * @param $data
*
* @return array queue message format
+ *
+ * @throws \EmptyRowException
*/
protected function parseRow($data) {
$msg = array();
@@ -264,6 +268,10 @@
/**
* Do any final transformation on a normalized and default-laden queue
* message. Overrides are specific to each upload source.
+ *
+ * @param array $msg
+ *
+ * @throws \WmfException
*/
protected function mungeMessage(&$msg) {
if (isset($msg['raw_contribution_type'])) {
@@ -562,6 +570,7 @@
*
* @param int $totalRows
* @param int $num_successful
+ * @param int $num_errors
* @param int $num_ignored
* @param int $num_duplicates
*/
@@ -608,8 +617,9 @@
/**
* Set a message relating to this output.
*
- * @param $uri
- * @param $type
+ * @param string $uri
+ * @param string $type
+ * @param int $count
*/
public function setMessage($uri, $type, $count) {
$row = ($count > 1) ? 'rows' : 'row';
--
To view, visit https://gerrit.wikimedia.org/r/394220
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I74cee89622b2dd7588534de5791dd1110538277a
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/crm
Gerrit-Branch: deployment
Gerrit-Owner: Eileen <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
