Pppery has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394234 )
Change subject: Re-enable
MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName sniff
......................................................................
Re-enable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName sniff
Change-Id: I420fd3640772f4127ca15603af00fd30aecc28c0
---
M .phpcs.xml
M includes/ApiQueryExtracts.php
2 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TextExtracts
refs/changes/34/394234/1
diff --git a/.phpcs.xml b/.phpcs.xml
index af73563..b15894e 100644
--- a/.phpcs.xml
+++ b/.phpcs.xml
@@ -3,7 +3,6 @@
<rule ref="./vendor/mediawiki/mediawiki-codesniffer/MediaWiki">
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingParamComment" />
<exclude
name="MediaWiki.Commenting.FunctionComment.MissingDocumentationPublic" />
- <exclude
name="MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName" />
<exclude
name="MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.NewLineComment" />
</rule>
<file>.</file>
diff --git a/includes/ApiQueryExtracts.php b/includes/ApiQueryExtracts.php
index 58c9dc3..bd41ad1 100644
--- a/includes/ApiQueryExtracts.php
+++ b/includes/ApiQueryExtracts.php
@@ -380,16 +380,17 @@
if ( $this->params['sectionformat'] == 'raw' ) {
return $matches[0];
}
- $func = __CLASS__ .
"::doSection_{$this->params['sectionformat']}";
+ $sectionformat = ucfirst( $this->params['sectionformat'] );
+ $func = __CLASS__ . "::doSection{$sectionformat}";
return call_user_func( $func, $matches[1], trim( $matches[2] )
);
}
- private static function doSection_wiki( $level, $text ) {
+ private static function doSectionWiki( $level, $text ) {
$bars = str_repeat( '=', $level );
return "\n$bars $text $bars";
}
- private static function doSection_plain( $level, $text ) {
+ private static function doSectionPlain( $level, $text ) {
return "\n$text";
}
--
To view, visit https://gerrit.wikimedia.org/r/394234
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I420fd3640772f4127ca15603af00fd30aecc28c0
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TextExtracts
Gerrit-Branch: master
Gerrit-Owner: Pppery <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
