jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/389054 )
Change subject: Some RTL improvements to the page selector
......................................................................
Some RTL improvements to the page selector
Bug: T171344
Change-Id: I71d44ffaf6dd830ace555a74adca4aabdfba43d6
---
M modules/ui/widgets/mw.cx.ui.PageSelectorWidget.js
M modules/ui/widgets/mw.cx.ui.TitleOptionWidget.js
2 files changed, 18 insertions(+), 0 deletions(-)
Approvals:
Amire80: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ui/widgets/mw.cx.ui.PageSelectorWidget.js
b/modules/ui/widgets/mw.cx.ui.PageSelectorWidget.js
index 0a54123..59079a3 100644
--- a/modules/ui/widgets/mw.cx.ui.PageSelectorWidget.js
+++ b/modules/ui/widgets/mw.cx.ui.PageSelectorWidget.js
@@ -96,6 +96,7 @@
optionWidgetData.numOfLanguages = !data.missing && ( OO.getProp(
data.originalData, 'langlinkscount' ) || 0 ) + 1;
optionWidgetData.missingInTargetLanguage = !OO.getProp(
data.originalData, 'langlinks' );
optionWidgetData.targetLanguage = this.targetLanguage;
+ optionWidgetData.sourceLanguage = this.language;
return optionWidgetData;
};
diff --git a/modules/ui/widgets/mw.cx.ui.TitleOptionWidget.js
b/modules/ui/widgets/mw.cx.ui.TitleOptionWidget.js
index af55412..5fac141 100644
--- a/modules/ui/widgets/mw.cx.ui.TitleOptionWidget.js
+++ b/modules/ui/widgets/mw.cx.ui.TitleOptionWidget.js
@@ -31,6 +31,23 @@
// TODO: Consider upstreaming this
this.imageUrl = config.imageUrl;
+ // This is sometimes wrong, but at least consistently wrong
with other places.
+ // For example: A title of a Song in English in Arabic
Wikipedia.
+ this.$label.prop( {
+ lang: config.sourceLanguage,
+ dir: $.uls.data.getDir( config.sourceLanguage )
+ } );
+
+ // The descriptions are always in the source language...
+ // ...except for redirect pages it is in the ui language
+ if ( !config.redirect ) {
+ this.$element.find(
'.mw-widget-titleOptionWidget-description' )
+ .prop( {
+ lang: config.sourceLanguage,
+ dir: $.uls.data.getDir(
config.sourceLanguage )
+ } );
+ }
+
if ( config.numOfLanguages ) {
this.numOfLanguages = config.numOfLanguages;
--
To view, visit https://gerrit.wikimedia.org/r/389054
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I71d44ffaf6dd830ace555a74adca4aabdfba43d6
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: Santhosh <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
