Imarlier has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394375 )
Change subject: webperf.py: Handle oversamples differently than regular samples
......................................................................
webperf.py: Handle oversamples differently than regular samples
When we receive an event, check for the presence of the "oversample" flag. If
present,
then send the data to a different key in graphite (or whatever backend system).
If the key is not present at all, assume that the sender is an older version of
the NavTiming
extension, and handle it normally.
Bug:T181413
Change-Id: I38b3a29f87adea3305dcdda5b573b40bba25ad87
---
M modules/webperf/files/navtiming.py
1 file changed, 8 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/75/394375/1
diff --git a/modules/webperf/files/navtiming.py
b/modules/webperf/files/navtiming.py
index df1952e..f7f22c5 100755
--- a/modules/webperf/files/navtiming.py
+++ b/modules/webperf/files/navtiming.py
@@ -405,7 +405,10 @@
ua = parse_ua(meta['userAgent']) or ('Other', '_')
for metric, value in metrics.items():
- prefix = 'frontend.navtiming'
+ if 'isOversample' in event and event['isOversample']:
+ prefix = 'frontend.oversample.navtiming'
+ else:
+ prefix = 'frontend.navtiming'
if is_sane(value):
yield make_stat(prefix, metric, site, auth, value)
@@ -477,7 +480,10 @@
yield make_count('frontend.navtiming_discard', 'isSane')
else:
for metric, value in metrics_nav2.items():
- prefix = 'frontend.navtiming2'
+ if 'isOversample' in event and event['isOversample']:
+ prefix = 'frontend.oversample.navtiing2'
+ else:
+ prefix = 'frontend.navtiming2'
yield make_stat(prefix, metric, site, auth, value)
yield make_stat(prefix, metric, site, 'overall', value)
yield make_stat(prefix, metric, 'overall', value)
--
To view, visit https://gerrit.wikimedia.org/r/394375
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I38b3a29f87adea3305dcdda5b573b40bba25ad87
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Imarlier <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
