Ladsgroup has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394390 )
Change subject: Stop adding "other usage" when we are using just the description
......................................................................
Stop adding "other usage" when we are using just the description
Description usage tracking has been implemented now ^_^
Bug: T176417
Change-Id: I9801d06c6f9f28107a43bb0160d4a4119a0e0089
---
M client/includes/DataAccess/Scribunto/WikibaseLanguageDependentLuaBindings.php
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/90/394390/1
diff --git
a/client/includes/DataAccess/Scribunto/WikibaseLanguageDependentLuaBindings.php
b/client/includes/DataAccess/Scribunto/WikibaseLanguageDependentLuaBindings.php
index 984814a..22eafdb 100644
---
a/client/includes/DataAccess/Scribunto/WikibaseLanguageDependentLuaBindings.php
+++
b/client/includes/DataAccess/Scribunto/WikibaseLanguageDependentLuaBindings.php
@@ -108,9 +108,7 @@
return [ null, null ];
}
- // XXX: This. Sucks. A lot.
- // Also notes about language fallbacks from getLabel apply
- $this->usageAccumulator->addOtherUsage( $entityId );
+ $this->usageAccumulator->addDescriptionUsage( $entityId,
$term->getLanguageCode() );
return [ $term->getText(), $term->getActualLanguageCode() ];
}
--
To view, visit https://gerrit.wikimedia.org/r/394390
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9801d06c6f9f28107a43bb0160d4a4119a0e0089
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
