Robert Vogel has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/394258 )
Change subject: BSFoundation: Removed isStored from ConfigDefinitions, as every
config with a definition is stored
......................................................................
BSFoundation: Removed isStored from ConfigDefinitions, as every config with a
definition is stored
Change-Id: I04f56e2d3211f0c20fcaa07eb1c41c41ae29ebd7
---
M src/ConfigDefinition.php
M src/ConfigDefinition/Favicon.php
M src/ConfigDefinition/FileExtensions.php
M src/ConfigDefinition/ImageExtensions.php
M src/ConfigDefinition/Logo.php
M src/ISetting.php
6 files changed, 0 insertions(+), 30 deletions(-)
Approvals:
Robert Vogel: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/ConfigDefinition.php b/src/ConfigDefinition.php
index ad10069..7d79ddc 100644
--- a/src/ConfigDefinition.php
+++ b/src/ConfigDefinition.php
@@ -92,14 +92,6 @@
}
/**
- * Returns if the config is stored in the database
- * @return boolean
- */
- public function isStored() {
- return false;
- }
-
- /**
* Returns if the config is a ResourceLoader variable
* @return boolean
*/
diff --git a/src/ConfigDefinition/Favicon.php b/src/ConfigDefinition/Favicon.php
index 6cb75c5..b1e54a0 100644
--- a/src/ConfigDefinition/Favicon.php
+++ b/src/ConfigDefinition/Favicon.php
@@ -11,8 +11,4 @@
public function getVariableName() {
return 'wg' . $this->getName();
}
-
- public function isStored() {
- return true;
- }
}
diff --git a/src/ConfigDefinition/FileExtensions.php
b/src/ConfigDefinition/FileExtensions.php
index f599125..cb60f7c 100644
--- a/src/ConfigDefinition/FileExtensions.php
+++ b/src/ConfigDefinition/FileExtensions.php
@@ -8,10 +8,6 @@
return 'bs-pref-imageextensions';
}
- public function isStored() {
- return true;
- }
-
public function isRLConfigVar() {
return true;
}
diff --git a/src/ConfigDefinition/ImageExtensions.php
b/src/ConfigDefinition/ImageExtensions.php
index 2b51452..c8e5f3f 100644
--- a/src/ConfigDefinition/ImageExtensions.php
+++ b/src/ConfigDefinition/ImageExtensions.php
@@ -8,10 +8,6 @@
return 'bs-pref-fileextensions';
}
- public function isStored() {
- return true;
- }
-
public function isRLConfigVar() {
return true;
}
diff --git a/src/ConfigDefinition/Logo.php b/src/ConfigDefinition/Logo.php
index 05a1e5a..31c72e5 100644
--- a/src/ConfigDefinition/Logo.php
+++ b/src/ConfigDefinition/Logo.php
@@ -11,8 +11,4 @@
public function getVariableName() {
return 'wg' . $this->getName();
}
-
- public function isStored() {
- return true;
- }
}
diff --git a/src/ISetting.php b/src/ISetting.php
index e872199..083abb4 100644
--- a/src/ISetting.php
+++ b/src/ISetting.php
@@ -37,12 +37,6 @@
/**
*
- * @return boolean, If this variable is stored in the database
- */
- public function isStored();
-
- /**
- *
* @return string, the message key for the label
*/
public function getLabelMessageKey();
--
To view, visit https://gerrit.wikimedia.org/r/394258
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I04f56e2d3211f0c20fcaa07eb1c41c41ae29ebd7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/BlueSpiceFoundation
Gerrit-Branch: master
Gerrit-Owner: Pwirth <[email protected]>
Gerrit-Reviewer: Ljonka <[email protected]>
Gerrit-Reviewer: Mglaser <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
