Dzahn has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394625 )

Change subject: wmcs: move standard includes from site to roles
......................................................................

wmcs: move standard includes from site to roles

Change-Id: I491de33e594c67b34b9e410f42ef8da1d519c79d
---
M manifests/site.pp
M modules/role/manifests/wmcs/openstack/labtest/web.pp
M modules/role/manifests/wmcs/openstack/labtestn/services.pp
M modules/role/manifests/wmcs/openstack/main/control.pp
M modules/role/manifests/wmcs/openstack/main/net.pp
M modules/role/manifests/wmcs/openstack/main/net_standby.pp
M modules/role/manifests/wmcs/openstack/main/nodepool.pp
7 files changed, 6 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/25/394625/1

diff --git a/manifests/site.pp b/manifests/site.pp
index 2cc083a..6ac7d4b 100644
--- a/manifests/site.pp
+++ b/manifests/site.pp
@@ -1079,7 +1079,6 @@
 node /labtestservices200[23]\.wikimedia\.org/ {
     role(wmcs::openstack::labtestn::services)
     include ::base::firewall
-    include ::standard
     interface::add_ip6_mapped { 'main': }
 }
 
@@ -1227,7 +1226,6 @@
     role(wmcs::openstack::main::control)
 
     include ::base::firewall
-    include ::standard
     include ::ldap::role::client::labs
 }
 
@@ -1241,7 +1239,6 @@
     role(wmcs::openstack::main::control)
 
     include ::base::firewall
-    include ::standard
     include ::ldap::role::client::labs
 }
 
@@ -1252,7 +1249,6 @@
     role(wmcs::openstack::labtest::web,
           mariadb::wikitech)
     include ::base::firewall
-    include ::standard
     include ::ldap::role::client::labs
 
     interface::add_ip6_mapped { 'main': }
@@ -1274,7 +1270,6 @@
 
 node 'labnet1001.eqiad.wmnet' {
     role(wmcs::openstack::main::net)
-    include ::standard
 }
 
 node /labnet100[34]\.eqiad\.wmnet/ {
@@ -1285,13 +1280,11 @@
 
 node 'labnet1002.eqiad.wmnet' {
     role(wmcs::openstack::main::net_standby)
-    include ::standard
 }
 
 node 'labnodepool1001.eqiad.wmnet' {
     $nagios_contact_group = 'admins,contint'
     role(wmcs::openstack::main::nodepool)
-    include ::standard
     include ::base::firewall
 }
 
diff --git a/modules/role/manifests/wmcs/openstack/labtest/web.pp 
b/modules/role/manifests/wmcs/openstack/labtest/web.pp
index 28d32a5..f45d26f 100644
--- a/modules/role/manifests/wmcs/openstack/labtest/web.pp
+++ b/modules/role/manifests/wmcs/openstack/labtest/web.pp
@@ -1,5 +1,6 @@
 class role::wmcs::openstack::labtest::web {
     system::role { $name: }
+    include ::standard
     include ::profile::openstack::labtest::cloudrepo
     include ::profile::openstack::labtest::clientlib
     include ::profile::openstack::labtest::observerenv
diff --git a/modules/role/manifests/wmcs/openstack/labtestn/services.pp 
b/modules/role/manifests/wmcs/openstack/labtestn/services.pp
index eefbae5..4511a93 100644
--- a/modules/role/manifests/wmcs/openstack/labtestn/services.pp
+++ b/modules/role/manifests/wmcs/openstack/labtestn/services.pp
@@ -1,4 +1,5 @@
 class role::wmcs::openstack::labtestn::services {
     system::role { $name: }
+    include ::standard
     include ::profile::openstack::labtestn::cloudrepo
 }
diff --git a/modules/role/manifests/wmcs/openstack/main/control.pp 
b/modules/role/manifests/wmcs/openstack/main/control.pp
index f65d901..ae03aa8 100644
--- a/modules/role/manifests/wmcs/openstack/main/control.pp
+++ b/modules/role/manifests/wmcs/openstack/main/control.pp
@@ -1,5 +1,6 @@
 class role::wmcs::openstack::main::control {
     system::role { $name: }
+    include ::standard
     include ::profile::openstack::main::observerenv
     include ::profile::openstack::main::rabbitmq
     include ::profile::openstack::main::keystone::service
diff --git a/modules/role/manifests/wmcs/openstack/main/net.pp 
b/modules/role/manifests/wmcs/openstack/main/net.pp
index 7441ab6..f440ab9 100644
--- a/modules/role/manifests/wmcs/openstack/main/net.pp
+++ b/modules/role/manifests/wmcs/openstack/main/net.pp
@@ -1,5 +1,6 @@
 class role::wmcs::openstack::main::net {
     system::role { $name: }
+    include ::standard
     include ::profile::openstack::main::cloudrepo
     include ::profile::openstack::main::clientlib
     include ::profile::openstack::main::observerenv
diff --git a/modules/role/manifests/wmcs/openstack/main/net_standby.pp 
b/modules/role/manifests/wmcs/openstack/main/net_standby.pp
index 9eccd60..7ea21b4 100644
--- a/modules/role/manifests/wmcs/openstack/main/net_standby.pp
+++ b/modules/role/manifests/wmcs/openstack/main/net_standby.pp
@@ -1,5 +1,6 @@
 class role::wmcs::openstack::main::net_standby {
     system::role { $name: }
+    include ::standard
     include ::profile::openstack::main::cloudrepo
     include ::profile::openstack::main::clientlib
     include ::profile::openstack::main::observerenv
diff --git a/modules/role/manifests/wmcs/openstack/main/nodepool.pp 
b/modules/role/manifests/wmcs/openstack/main/nodepool.pp
index 7e77871..5fec0cb 100644
--- a/modules/role/manifests/wmcs/openstack/main/nodepool.pp
+++ b/modules/role/manifests/wmcs/openstack/main/nodepool.pp
@@ -1,4 +1,5 @@
 class role::wmcs::openstack::main::nodepool {
     system::role { $name: }
+    include ::standard
     include ::profile::openstack::main::nodepool::service
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/394625
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I491de33e594c67b34b9e410f42ef8da1d519c79d
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to