[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[specialpages]: Upgrade checkboxes to ToggleSwitches on options form

[Jdlrobson (Code Review)]

Jdlrobson has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/394634 )

Change subject: Upgrade checkboxes to ToggleSwitches on options form
......................................................................

Upgrade checkboxes to ToggleSwitches on options form

Bug: T169807
Change-Id: Ic2b203478f2d123129296d54ced0fd9ed9f070a2
---
M resources/mobile.special.mobileoptions.scripts/mobileoptions.js
1 file changed, 12 insertions(+), 8 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend 
refs/changes/34/394634/1

diff --git a/resources/mobile.special.mobileoptions.scripts/mobileoptions.js 
b/resources/mobile.special.mobileoptions.scripts/mobileoptions.js
index 4f454f9..992e82b 100644
--- a/resources/mobile.special.mobileoptions.scripts/mobileoptions.js
+++ b/resources/mobile.special.mobileoptions.scripts/mobileoptions.js
@@ -95,9 +95,9 @@
        function addExpandAllSectionsToForm( $form ) {
                var cb, cbField;
 
-               cb = new OO.ui.CheckboxInputWidget( {
+               cb = new OO.ui.ToggleSwitchWidget( {
                        name: EXPAND_SECTIONS_KEY,
-                       selected: storage.get( EXPAND_SECTIONS_KEY ) === 'true'
+                       value: storage.get( EXPAND_SECTIONS_KEY ) === 'true'
                } );
                cbField = new OO.ui.FieldLayout(
                        cb,
@@ -108,8 +108,8 @@
                                ).$element
                        }
                );
-               cb.on( 'change', function () {
-                       storage.set( EXPAND_SECTIONS_KEY, this.isSelected() ? 
'true' : 'false' );
+               cb.on( 'change', function ( value ) {
+                       storage.set( EXPAND_SECTIONS_KEY, value );
                        notify();
                }.bind( cb ) );
 
@@ -123,15 +123,19 @@
         * @ignore
         */
        function initLocalStorageElements() {
-               var
+               var cb,
                        enableToggle = OO.ui.infuse( $( '#enable-beta-toggle' ) 
),
                        $form = $( '#mobile-options' );
 
+               cb = new OO.ui.ToggleSwitchWidget( {
+                       value: enableToggle.isSelected()
+               } )
+               enableToggle.$element.replaceWith( cb.$element );
                // The beta toggle will now work without clicking submit
-               enableToggle.on( 'change', function () {
-                       cookie( 'optin', this.isSelected() ? 'beta' : '' );
+               cb.on( 'change', function ( value ) {
+                       cookie( 'optin', value ? 'beta' : '' );
                        notify();
-               }.bind( enableToggle ) );
+               }.bind( cb ) );
 
                if ( mw.config.get( 'wgMFExpandAllSectionsUserOption' ) ) {
                        addExpandAllSectionsToForm( $form );

-- 
To view, visit https://gerrit.wikimedia.org/r/394634
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2b203478f2d123129296d54ced0fd9ed9f070a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: specialpages
Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits