awjrichards has submitted this change and it was merged.
Change subject: Remove tumbleweed code for WLM banner
......................................................................
Remove tumbleweed code for WLM banner
This was added to allow banners in WLM.
Going forward we should use CentralNotice instead
Change-Id: Ibf582717ca2f8c513177b2340c9a1f70c58d2b3e
---
M includes/skins/SkinMobileBase.php
1 file changed, 0 insertions(+), 18 deletions(-)
Approvals:
JGonera: Looks good to me, but someone else must approve
awjrichards: Verified; Looks good to me, approved
jenkins-bot: Checked
diff --git a/includes/skins/SkinMobileBase.php
b/includes/skins/SkinMobileBase.php
index 297db88..75ad4b7 100644
--- a/includes/skins/SkinMobileBase.php
+++ b/includes/skins/SkinMobileBase.php
@@ -57,24 +57,6 @@
$this->extMobileFrontend = $extMobileFrontend;
}
- /**
- * createDismissableBanner
- *
- * @param $id string: unique identification string for banner to
distinguish it from other banners
- * @param $content string: html string to put in banner
- * @param $classNames string: additional classes that can be added to
the banner. In particular used to target certain devices (e.g. android)
- * @param $bannerStyle string: additional styling for banner
- * @return string
- */
- public function createDismissableBanner( $id, $content="",
$classNames="", $bannerStyle="" ) {
- return <<<HTML
- <div class="mw-mf-banner {$classNames}"
id="mw-mf-banner-{$id}"
- style="{$bannerStyle}">
- {$content}
- </div>
-HTML;
- }
-
public function outputPage( OutputPage $out = null ) {
global $wgMFNoindexPages;
wfProfileIn( __METHOD__ );
--
To view, visit https://gerrit.wikimedia.org/r/56618
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf582717ca2f8c513177b2340c9a1f70c58d2b3e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jdlrobson <[email protected]>
Gerrit-Reviewer: JGonera <[email protected]>
Gerrit-Reviewer: awjrichards <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
