jenkins-bot has submitted this change and it was merged. ( 
https://gerrit.wikimedia.org/r/394739 )

Change subject: Compatible with php7.2
......................................................................


Compatible with php7.2

Fix in php7.2, extension display "Fatal error: Declaration of 
HTMLFeatureField::getInputHTML($value) must be compatible with 
NewHTMLCheckField::getInputHTML($value, $attr = NULL)" issue.

Bug: T181821
Change-Id: Ib6e80acaef1198d4016955b275e8edddb5cbdab0
---
M includes/HTMLFeatureField.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Legoktm: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/HTMLFeatureField.php b/includes/HTMLFeatureField.php
index d40ab6f..a4f0376 100644
--- a/includes/HTMLFeatureField.php
+++ b/includes/HTMLFeatureField.php
@@ -280,7 +280,7 @@
                return $html;
        }
 
-       function getInputHTML( $value ) {
+       function getInputHTML( $value, $attr = null ) {
                $html = '';
 
                $divClasses = [

-- 
To view, visit https://gerrit.wikimedia.org/r/394739
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib6e80acaef1198d4016955b275e8edddb5cbdab0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/BetaFeatures
Gerrit-Branch: master
Gerrit-Owner: 星耀晨曦 <liguangjie4...@hotmail.com>
Gerrit-Reviewer: Aklapper <aklap...@wikimedia.org>
Gerrit-Reviewer: Legoktm <lego...@member.fsf.org>
Gerrit-Reviewer: Reedy <re...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
Gerrit-Reviewer: 星耀晨曦 <liguangjie4...@hotmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to