jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394840 )
Change subject: Use only PSR2.Files.EndFileNewline ...................................................................... Use only PSR2.Files.EndFileNewline The PSR2 sniff was picked over the Generic.Files.EndFileNewline one because the PSR2 version specifically looks for Unix file endings ("\n"). Bug: T179998 Change-Id: I66992c8c35fdab584e05dd39721e3ef1b6dd1cea --- M MediaWiki/ruleset.xml 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Umherirrender: Looks good to me, approved jenkins-bot: Verified diff --git a/MediaWiki/ruleset.xml b/MediaWiki/ruleset.xml index 538fa79..bdabe2e 100644 --- a/MediaWiki/ruleset.xml +++ b/MediaWiki/ruleset.xml @@ -29,7 +29,6 @@ <rule ref="Generic.CodeAnalysis.UselessOverridingMethod" /> --> <rule ref="Generic.Files.ByteOrderMark" /> - <rule ref="Generic.Files.EndFileNewline" /> <rule ref="Generic.Files.LineEndings" /> <rule ref="Generic.Files.LineLength"> <properties> -- To view, visit https://gerrit.wikimedia.org/r/394840 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I66992c8c35fdab584e05dd39721e3ef1b6dd1cea Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/tools/codesniffer Gerrit-Branch: master Gerrit-Owner: Legoktm <lego...@member.fsf.org> Gerrit-Reviewer: Addshore <addshorew...@gmail.com> Gerrit-Reviewer: Umherirrender <umherirrender_de...@web.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits