jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/394302 )
Change subject: Get page fromdbmaster in Importer
......................................................................
Get page fromdbmaster in Importer
Due to possible slave lag the page might not exist yet.
So get from master.
The 2 selects we now have from master dbs in the Importer
probably hint that we should be doing this in jobs.
Bug: T181391
Change-Id: Ia246302dc0db439dcf25760337a98e169569d828
---
M src/Services/Importer.php
1 file changed, 6 insertions(+), 2 deletions(-)
Approvals:
jenkins-bot: Verified
Andrew-WMDE: Looks good to me, approved
diff --git a/src/Services/Importer.php b/src/Services/Importer.php
index da5128e..0d10dc9 100644
--- a/src/Services/Importer.php
+++ b/src/Services/Importer.php
@@ -145,10 +145,14 @@
User $user
) {
$config = MediaWikiServices::getInstance()->getMainConfig();
- $page = WikiPage::newFromID( $articleIdForUpdate );
+ /**
+ * Pass fromdbmaster as the page has only just been created and
in
+ * multi db setups slaves will have lag.
+ */
+ $page = WikiPage::newFromID( $articleIdForUpdate,
'fromdbmaster' );
if ( $page === null ) {
throw new RuntimeException(
- 'Failed to get wikipedia to create import edit
with id: ' . $articleIdForUpdate
+ 'Failed to get wikipedia to create import edit
with page id: ' . $articleIdForUpdate
);
}
$editResult = $page->doEditContent(
--
To view, visit https://gerrit.wikimedia.org/r/394302
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia246302dc0db439dcf25760337a98e169569d828
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/FileImporter
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Andrew-WMDE <[email protected]>
Gerrit-Reviewer: Tobias Gritschacher <[email protected]>
Gerrit-Reviewer: WMDE-Fisch <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
