jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/394988 )
Change subject: Fix possible crash when swiping in Randomizer.
......................................................................
Fix possible crash when swiping in Randomizer.
Bug: T181874
Change-Id: I97c7b4c766833f145157438bdc183669a015c01c
---
M app/src/main/java/org/wikipedia/random/RandomItemFragment.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Dbrant: Looks good to me, approved
jenkins-bot: Verified
diff --git a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
index 2a6aec5..adbc7fb 100644
--- a/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
+++ b/app/src/main/java/org/wikipedia/random/RandomItemFragment.java
@@ -106,6 +106,9 @@
observer.addOnGlobalLayoutListener(new
ViewTreeObserver.OnGlobalLayoutListener() {
@Override
public void onGlobalLayout() {
+ if (!isAdded() || extractView == null) {
+ return;
+ }
extractView.setMaxLines(extractView.getHeight() /
extractView.getLineHeight());
extractView.getViewTreeObserver().removeOnGlobalLayoutListener(this);
}
--
To view, visit https://gerrit.wikimedia.org/r/394988
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I97c7b4c766833f145157438bdc183669a015c01c
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <[email protected]>
Gerrit-Reviewer: Brion VIBBER <[email protected]>
Gerrit-Reviewer: Cooltey <[email protected]>
Gerrit-Reviewer: Dbrant <[email protected]>
Gerrit-Reviewer: Sharvaniharan <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits