Seb35 has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394993 )
Change subject: Improve discoverability of $wgMediaWikiFarmSyslog
......................................................................
Improve discoverability of $wgMediaWikiFarmSyslog
Particularly for monoversion case, $wgMediaWikiFarmSyslog is included in the
template config file, hence people will be aware some things are logged through
syslog. Also tread $wgMediaWikiFarmSyslog === null similarly to === false,
hence when people remove this config parameter it will not spam the logs (and
now it is pretty sure they ''knowingly'' remove this config parameter).
Bug: T181212
Change-Id: Ie68cd1260416c2ef22eaa475717781f5183841ca
---
M docs/config/LocalSettings.php
M src/MediaWikiFarm.php
2 files changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MediaWikiFarm
refs/changes/93/394993/1
diff --git a/docs/config/LocalSettings.php b/docs/config/LocalSettings.php
index 5af9feb..2f8e644 100644
--- a/docs/config/LocalSettings.php
+++ b/docs/config/LocalSettings.php
@@ -9,9 +9,15 @@
}
// Configuration directory.
+// Type: string
// There must be a file 'farms.yml' or 'farms.php' or 'farms.json' inside.
$wgMediaWikiFarmConfigDir = '/etc/mediawiki';
+// Syslog tag.
+// Type: string|false
+$wgMediaWikiFarmSyslog = 'mediawikifarm';
+
+
# Include the code.
require "$IP/extensions/MediaWikiFarm/MediaWikiFarm.php";
diff --git a/src/MediaWikiFarm.php b/src/MediaWikiFarm.php
index 71596cd..cf7438e 100644
--- a/src/MediaWikiFarm.php
+++ b/src/MediaWikiFarm.php
@@ -602,7 +602,7 @@
static function prepareLog( $wgMediaWikiFarmSyslog, $wgMediaWikiFarm,
$exception = null ) {
$log = array();
- if( $wgMediaWikiFarmSyslog === false ) {
+ if( $wgMediaWikiFarmSyslog === false || $wgMediaWikiFarmSyslog
=== null ) {
return $log;
}
--
To view, visit https://gerrit.wikimedia.org/r/394993
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie68cd1260416c2ef22eaa475717781f5183841ca
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MediaWikiFarm
Gerrit-Branch: master
Gerrit-Owner: Seb35 <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
