jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/386633 )
Change subject: Remove unused $batchSize in SqlUsageTracker
......................................................................
Remove unused $batchSize in SqlUsageTracker
I can see this is meant to be injected later, but this never happend.
Right now it is unused, dead code.
Change-Id: I2e7648e2f35b152a359820eabf593166ad4d4195
---
M client/includes/Usage/Sql/SqlUsageTracker.php
1 file changed, 1 insertion(+), 30 deletions(-)
Approvals:
Addshore: Looks good to me, approved
jenkins-bot: Verified
diff --git a/client/includes/Usage/Sql/SqlUsageTracker.php
b/client/includes/Usage/Sql/SqlUsageTracker.php
index 7dbb1dd..02ec945 100644
--- a/client/includes/Usage/Sql/SqlUsageTracker.php
+++ b/client/includes/Usage/Sql/SqlUsageTracker.php
@@ -42,11 +42,6 @@
private $disabledUsageAspects;
/**
- * @var int
- */
- private $batchSize = 100;
-
- /**
* @param EntityIdParser $idParser
* @param SessionConsistentConnectionManager $connectionManager
* @param string[] $disabledUsageAspects
@@ -67,31 +62,7 @@
* @return EntityUsageTable
*/
private function newUsageTable( Database $db ) {
- return new EntityUsageTable( $this->idParser, $db,
$this->batchSize );
- }
-
- /**
- * Sets the query batch size.
- *
- * @param int $batchSize
- *
- * @throws InvalidArgumentException
- */
- public function setBatchSize( $batchSize ) {
- if ( !is_int( $batchSize ) || $batchSize < 1 ) {
- throw new InvalidArgumentException( '$batchSize must be
an integer >= 1' );
- }
-
- $this->batchSize = $batchSize;
- }
-
- /**
- * Returns the current query batch size.
- *
- * @return int
- */
- public function getBatchSize() {
- return $this->batchSize;
+ return new EntityUsageTable( $this->idParser, $db );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/386633
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2e7648e2f35b152a359820eabf593166ad4d4195
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Addshore <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: Daniel Kinzler <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Ladsgroup <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
