[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix style of individual on-this-day items.

[Dbrant (Code Review)]

Dbrant has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/395119 )

Change subject: Fix style of individual on-this-day items.
......................................................................

Fix style of individual on-this-day items.

Change-Id: Ie7f96ed84753e0df9d1380534627423c437e5716
---
M app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayPagesViewHolder.java
M app/src/main/res/layout/item_on_this_day_pages.xml
2 files changed, 4 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/19/395119/1

diff --git 
a/app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayPagesViewHolder.java 
b/app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayPagesViewHolder.java
index 3adaa10..9781542 100644
--- 
a/app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayPagesViewHolder.java
+++ 
b/app/src/main/java/org/wikipedia/feed/onthisday/OnThisDayPagesViewHolder.java
@@ -7,7 +7,6 @@
 import android.support.annotation.Nullable;
 import android.support.v7.widget.CardView;
 import android.support.v7.widget.RecyclerView;
-import android.text.TextUtils;
 import android.view.View;
 import android.widget.TextView;
 
@@ -56,12 +55,7 @@
     }
 
     private void setImage(@Nullable String url) {
-        if (!TextUtils.isEmpty(url)) {
-            pageItemImageView.setVisibility(View.VISIBLE);
-            pageItemImageView.loadImage(Uri.parse(url));
-        } else {
-            pageItemImageView.setVisibility(View.GONE);
-        }
+        pageItemImageView.loadImage(url == null ? null : Uri.parse(url));
     }
 
     @OnClick(R.id.parent) void onBaseViewClicked() {
diff --git a/app/src/main/res/layout/item_on_this_day_pages.xml 
b/app/src/main/res/layout/item_on_this_day_pages.xml
index 64a273b..b233e5e 100644
--- a/app/src/main/res/layout/item_on_this_day_pages.xml
+++ b/app/src/main/res/layout/item_on_this_day_pages.xml
@@ -12,10 +12,11 @@
         android:orientation="horizontal">
 
         <org.wikipedia.views.FaceAndColorDetectImageView
+            style="@style/SimpleDraweeViewPlaceholder.Article"
             android:id="@+id/page_list_item_image"
             android:layout_width="72dp"
             android:layout_height="match_parent"
-            android:visibility="gone"
+            app:backgroundImage="@color/base80"
             app:actualImageScaleType="centerCrop" />
 
         <LinearLayout
@@ -36,7 +37,7 @@
                 android:maxLines="1"
                 android:textColor="?attr/primary_text_color" />
 
-            <TextView
+            <org.wikipedia.views.GoneIfEmptyTextView
                 android:id="@+id/page_list_item_description"
                 style="@style/RtlAwareTextView"
                 android:layout_width="wrap_content"

-- 
To view, visit https://gerrit.wikimedia.org/r/395119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie7f96ed84753e0df9d1380534627423c437e5716
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits