Legoktm has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395163 )
Change subject: Check to make sure fopen() worked before trying to write to the
file
......................................................................
Check to make sure fopen() worked before trying to write to the file
Bug: T174086
Change-Id: Id095dd171cdd1d2c8f32e6254154e5a68ef3f1d5
---
M DPLMain.php
1 file changed, 7 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DynamicPageList
refs/changes/63/395163/1
diff --git a/DPLMain.php b/DPLMain.php
index a2bcce0..4a3b644 100644
--- a/DPLMain.php
+++ b/DPLMain.php
@@ -3235,10 +3235,13 @@
}
$cacheTimeStamp = self::prettyTimeStamp( date( 'YmdHis'
) );
$cFile = fopen( $cacheFile, 'w' );
- fwrite( $cFile, $originalInput );
- fwrite( $cFile, "+++\n" );
- fwrite( $cFile, $output );
- fclose( $cFile );
+ if ( $cFile !== false ) {
+ fwrite( $cFile, $originalInput );
+ fwrite( $cFile, "+++\n" );
+ fwrite( $cFile, $output );
+ fclose( $cFile );
+ }
+ // @todo log something if couldn't write to cache?
$dplElapsedTime = time() -$dplStartTime;
if ( $logger->iDebugLevel >= 2 ) {
$output .= "{{Extension DPL
cache|mode=update|page={{FULLPAGENAME}}|cache=$DPLCache|date=$cacheTimeStamp|age=0|now="
.
--
To view, visit https://gerrit.wikimedia.org/r/395163
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Id095dd171cdd1d2c8f32e6254154e5a68ef3f1d5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DynamicPageList
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
