Bmansurov has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395554 )
Change subject: Remove wrong FIXME
......................................................................
Remove wrong FIXME
We're not going to decommission Extension:Collection anytime soon. The
FIXME meant decommissioning OCG, but there's no logic related to OCG in
that piece of code there.
Bug: T176755
Change-Id: I2da57a4c4107337e0aed8cb04cb0e0b4a067d293
---
M src/ElectronPdfServiceHooks.php
1 file changed, 0 insertions(+), 1 deletion(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ElectronPdfService
refs/changes/54/395554/1
diff --git a/src/ElectronPdfServiceHooks.php b/src/ElectronPdfServiceHooks.php
index e470c1d..9b3bfa1 100644
--- a/src/ElectronPdfServiceHooks.php
+++ b/src/ElectronPdfServiceHooks.php
@@ -31,7 +31,6 @@
return true;
}
- // FIXME: remove logic related to Extension:Collection once we
decommission it: T176755.
if ( $config->has( 'CollectionFormats' ) && array_key_exists(
'coll-print_export', $bar ) ) {
$index = self::getIndexOfDownloadPdfSidebarItem(
$bar['coll-print_export'],
--
To view, visit https://gerrit.wikimedia.org/r/395554
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2da57a4c4107337e0aed8cb04cb0e0b4a067d293
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ElectronPdfService
Gerrit-Branch: master
Gerrit-Owner: Bmansurov <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
